★ wanayoo — archive 1999 https://github.com/livecode/livecode/pull/6317Nouvelle recherche | Portail wanayoo
Skip to content

/ livecode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[[ Bugfix 20951 ]] Fixed bug causing garbage at end of repeat to be ignored #6317

Merged
merged 2 commits into from Mar 7, 2019
Merged

[[ Bugfix 20951 ]] Fixed bug causing garbage at end of repeat to be ignored #6317

merged 2 commits into from Mar 7, 2019

Conversation

@abrisan
Copy link
Contributor

@abrisan abrisan commented Feb 5, 2018

No description provided.

@livecodeali
livecodeali requested changes Feb 5, 2018
View changes
tests/lcs/parser/repeat.parsertest Outdated
repeat with i = 1 to 10
end repeat
end mouseUp
%EXPECT_PASS

This comment has been minimized.

Sign in to view
@livecodeali

livecodeali Feb 5, 2018
Member

this needs to be %EXPECT PASS (no underscore)
tests/lcs/parser/repeat.parsertest Outdated
repeat with i = 1 to 10 step 1
end repeat
end mouseUp
%EXPECT_PASS

This comment has been minimized.

Sign in to view
@livecodeali

livecodeali Feb 5, 2018
Member

same here
tests/lcs/parser/repeat.parsertest Outdated
end repeat
end mouseUp
%EXPECT PE_REPEAT_BADCOND AT ALEX
%SUCCESS

This comment has been minimized.

Sign in to view
@livecodeali

livecodeali Feb 5, 2018
Member

This needs to be

%EXPECT PASS
%ERROR PE_REPEAT_BADCOND AT AFTER_ENDVALUE

(and rename your label from ALEX to AFTER_ENDVALUE, just so it is more instructive of the intended position). You can still include alex in your garbage if you want, just do it as

repeat with i = 1 to 10 %{AFTER_ENDVALUE} alex 10

:-)
@abrisan abrisan force-pushed the bugfix-20951 branch 2 times, most recently from 5e3f540 to d04bb2b Feb 5, 2018
@abrisan
Copy link
Contributor Author

@abrisan abrisan commented Feb 5, 2018

@livecodeali Should be fixed now
@livecodeali
livecodeali reviewed Feb 5, 2018
View changes
tests/lcs/parser/repeat.parsertest Outdated
end repeat
end mouseUp
%EXPECT PE_REPEAT_BADCOND AT AFTER_ENDVALUE
%SUCCESS

This comment has been minimized.

Sign in to view
@livecodeali

livecodeali Feb 5, 2018
Member

This bit is still not quite right:

%EXPECT PASS
%ERROR PE_REPEAT_BADCOND AT AFTER_ENDVALUE
@abrisan abrisan force-pushed the bugfix-20951 branch from d04bb2b to 18b35a2 Feb 5, 2018
@abrisan
Copy link
Contributor Author

@abrisan abrisan commented Feb 5, 2018

@livecodeali now?
@livecodeali
Copy link
Member

@livecodeali livecodeali commented Feb 5, 2018

@livecodealex there shouldn't be a %SUCCESS on that one
@livecodeali
Copy link
Member

@livecodeali livecodeali commented Feb 5, 2018

Sorry, I didn't make that at all clear originally
@abrisan abrisan force-pushed the bugfix-20951 branch from 18b35a2 to b5f679d Feb 5, 2018
@alexbrisan1234
[[ Bugfix 20951 ]] Fixed bug causing garbage at end of repeat to be i…
Loading status checks…
fffc0a6 
…gnored
@abrisan abrisan force-pushed the bugfix-20951 branch from b5f679d to fffc0a6 Feb 5, 2018
@livecodeali
livecodeali approved these changes Feb 5, 2018
View changes
@runrevmark runrevmark added this to the future milestone Feb 5, 2018
@abrisan
Copy link
Contributor Author

@abrisan abrisan commented Feb 5, 2018

As @runrevmark nicely pointed out, this is probably failing due to the fact that the IDE tests cannot run. I wonder what we should do in this situation...
@livecodeali
Copy link
Member

@livecodeali livecodeali commented Feb 5, 2018

Ah! Well, it probably makes sense to submit a PR fixing the bits in the IDE (this can go into any branch - probably 8.1) and then once it is merged up we can trigger Travis to run again
@runrevmark runrevmark added bug LCS labels Feb 6, 2018
@abrisan
Copy link
Contributor Author

@abrisan abrisan commented Feb 12, 2018

@livecodeali on it
@alexbrisan1234
[[ Bug 20951 ]] Fixed IDE file
Loading status checks…
a9ad5d2
@abrisan
Copy link
Contributor Author

@abrisan abrisan commented Feb 12, 2018

Testing depends on livecode/livecode-ide#1910
@livecodeali livecodeali modified the milestones: future, 9.1.0-dp-1 Apr 17, 2018
@livecodeali
Copy link
Member

@livecodeali livecodeali commented Apr 18, 2018

@livecode-vulcan review ok a9ad5d2
@livecode-vulcan
Copy link
Contributor

@livecode-vulcan livecode-vulcan commented Apr 18, 2018

💙 review by @livecodeali ok a9ad5d2
livecode-vulcan added a commit that referenced this pull request Apr 18, 2018
@livecode-vulcan
Auto-merge pull request #6317 from livecodealex/bugfix-20951
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
39cf145 
[[ Bugfix 20951 ]] Fixed bug causing garbage at end of repeat to be ignored
@livecode-vulcan
Copy link
Contributor

@livecode-vulcan livecode-vulcan commented Apr 18, 2018

😞 test failure a9ad5d2

  • try-community-armv6-android-api8: success
  • try-community-armv6-android-api9: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos11.3: success
  • try-community-universal-ios-iphonesimulator11.3: failure
  • try-community-universal-mac-macosx10.6: failure
  • try-community-universal-mac-macosx10.9: failure
  • try-community-x86-linux-debian7: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian7: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: failure
  • try-community-x86_64-win32: pending
@livecodepanos
Copy link
Contributor

@livecodepanos livecodepanos commented Mar 7, 2019

@livecode-vulcan retry a9ad5d2
livecode-vulcan added a commit that referenced this pull request Mar 7, 2019
@livecode-vulcan
Auto-merge pull request #6317 from livecodealex/bugfix-20951
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
22f4cf8 
[[ Bugfix 20951 ]] Fixed bug causing garbage at end of repeat to be ignored
@livecode-vulcan
Copy link
Contributor

@livecode-vulcan livecode-vulcan commented Mar 7, 2019

😎 test success a9ad5d2

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-sdk26_ndk16r15: success
  • try-community-arm64-android-sdk26_ndk16r15: success
  • try-community-x86-android-sdk26_ndk16r15: success
  • try-community-x86_64-android-sdk26_ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos12.1: success
  • try-community-universal-ios-iphonesimulator12.1: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success
@livecodepanos livecodepanos merged commit 6ecab4f into develop Mar 7, 2019
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/vulcan/cla Contributor Agreement signed by @livecodealex
continuous-integration/vulcan/pr The Vulcan build succeeded on 13 builders
continuous-integration/vulcan/review Approved by reviewer @livecodeali
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@livecodeali livecodeali

Assignees
No one assigned
Labels
LCS bug vulcan/reviewed
Projects
None yet
Milestone
9.5.0-dp-1
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@abrisan @livecodeali @livecode-vulcan @livecodepanos @runrevmark @alexbrisan1234
You can’t perform that action at this time.