Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[[ Bug 20482 ]] Use replacement chars on a cluster rather than glyph basis #6340
Conversation
…basis We need fields to visually represent grapheme boundaries so that navigation works as expected, so deal with glyph info on a cluster by cluster basis, replacing whole clusters with a replacement char if any part of it is unsupported by the current font or fallback font.
|
@livecode-vulcan review ok 2565cfe |
|
|
livecode-vulcan
added a commit
that referenced
this pull request
Mar 4, 2018
[[ Bug 20482 ]] Use replacement chars on a cluster rather than glyph basis We need fields to visually represent grapheme boundaries so that navigation works as expected, so deal with glyph info on a cluster by cluster basis, replacing whole clusters with a replacement char if any part of it is unsupported by the current font or fallback font.
|
|
@livecode-vulcan review ok 6d7ea85 |
|
|
livecode-vulcan
added a commit
that referenced
this pull request
Mar 5, 2018
[[ Bug 20482 ]] Use replacement chars on a cluster rather than glyph basis We need fields to visually represent grapheme boundaries so that navigation works as expected, so deal with glyph info on a cluster by cluster basis, replacing whole clusters with a replacement char if any part of it is unsupported by the current font or fallback font.
|
|
Not sure what's going on here, think I must be missing a commit or forgot to commit something. |
|
@montegoulding Ok, fixed and tested! |
|
@livecode-vulcan review ok da7045d Sorry I missed that! |
|
|
livecode-vulcan
added a commit
that referenced
this pull request
Mar 6, 2018
[[ Bug 20482 ]] Use replacement chars on a cluster rather than glyph basis We need fields to visually represent grapheme boundaries so that navigation works as expected, so deal with glyph info on a cluster by cluster basis, replacing whole clusters with a replacement char if any part of it is unsupported by the current font or fallback font.
|
557cfa4
into
livecode:develop
4 checks passed
4 checks passed
continuous-integration/vulcan/cla
Contributor Agreement signed by @livecodeali
continuous-integration/vulcan/pr
The Vulcan build succeeded on 13 builders
continuous-integration/vulcan/review
Approved by reviewer @montegoulding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We need fields to visually represent grapheme boundaries so that navigation
works as expected, so deal with glyph info on a cluster by cluster basis,
replacing whole clusters with a replacement char if any part of it is
unsupported by the current font or fallback font.