Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
DOC: Changes to screenshots plots. #7821
Conversation
tacaswell
added this to the
2.0 (style change major release)
milestone
Jan 13, 2017
|
I think having the images generated is a great idea, and this can be done by adding them to the gallery and linking them from the gallery. You can look in scikit-learn how it is done there, thought sphinx-gallery generates more plots than our current gallery system, so it needs to be adapted a bit:
(This can be found here: https://github.com/scikit-learn/scikit-learn/blob/master/doc/themes/scikit-learn/layout.html) |
|
After discussing with @tacaswell, we're going to merge this as is and backport ASAP to 2.x in preparation for the release. |
NelleV
merged commit e0a3da8
into matplotlib:master
Jan 16, 2017
QuLogic
added the
Documentation
label
Jan 16, 2017
|
Backported to |
|
@NelleV This probably the best solution. I took a look at the gallery extension and I did not understand how to generate plots without having a rst-page. |
vollbier commentedJan 13, 2017
•
edited
Before:
After:
@NelleV As stated in #7740, I don't have strong preferences concerning
doc/make.py. If it helps with your future work, I can restore the original behavior of utilizing static images for the front page plots (If you prefer to do that yourself in this pull request, feel free).