DOC: Changes to screenshots plots. #7821

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
4 participants
Contributor

vollbier commented Jan 13, 2017 • edited

  • Removed ugly pie chart as requested from @efiring in PR #7740 and bug #7704.
  • Reduced the font size from 20 pt to 15 pt of the labels in the scatter plot (which is matter of taste, I guess).
  • Changed y-range in the simple plot to work around a strange bounding box problem of the y-label (I did not understand what's going on here - it seems to have something to do with the minus sign):

Before:

simple_plot1_before

After:

simple_plot1_after

@NelleV As stated in #7740, I don't have strong preferences concerning doc/make.py. If it helps with your future work, I can restore the original behavior of utilizing static images for the front page plots (If you prefer to do that yourself in this pull request, feel free).

@vollbier vollbier Made some changes to showcase plots plots.
* removed ugly pie chart
* changed fontsize of labels in scatter plot
* changed y-range in sine plot to work around bounding box problem.
8f3e013
Contributor

NelleV commented Jan 13, 2017

I think having the images generated is a great idea, and this can be done by adding them to the gallery and linking them from the gallery. You can look in scikit-learn how it is done there, thought sphinx-gallery generates more plots than our current gallery system, so it needs to be adapted a bit:

		  <div class="item">
		    <a href="{{pathto('auto_examples/neighbors/plot_species_kde') }}">
		      <img src="/old?u=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F7821%2F_images%2Fsphx_glr_plot_species_kde_thumb.png&y=1999"></a>
		  </div>

(This can be found here: https://github.com/scikit-learn/scikit-learn/blob/master/doc/themes/scikit-learn/layout.html)

Contributor

NelleV commented Jan 16, 2017

After discussing with @tacaswell, we're going to merge this as is and backport ASAP to 2.x in preparation for the release.

@NelleV NelleV merged commit e0a3da8 into matplotlib:master Jan 16, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage decreased (-0.002%) to 62.098%
Details

NelleV referenced this pull request Jan 16, 2017

Merged

Backports to 2.x #7839

Member

QuLogic commented Jan 16, 2017

Backported to v2.x as b424478.

Contributor

vollbier commented Jan 16, 2017

@NelleV This probably the best solution. I took a look at the gallery extension and I did not understand how to generate plots without having a rst-page.

vollbier deleted the vollbier:remove_showcase_piechart branch Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment