This repository has been archived by the owner. It is now read-only.
Fixed Hello constructor this.state.currentEnthusiasm assigment #260
Conversation
…teful Components + commentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
There's was an overlooked behavior inconsistency between the assignment of
this.state.currentEnthusiasmassigment at the Hello component constructor and the expect behavior in the test 'throws when the enthusiasm level is 0'.I fixed the assignment rather than the test itself so that the wanted behavior will work. When
enthusiamLevelis 0 it will now actually throw and error instead of bypassing thefalsyvalue and settingthis.state.currentEnthusiasmto 1.