★ wanayoo — archive 1999 https://github.com/microsoft/TypeScript-React-Starter/pull/260Nouvelle recherche | Portail wanayoo
Skip to content
This repository has been archived by the owner. It is now read-only.

Fixed Hello constructor this.state.currentEnthusiasm assigment #260

Open
wants to merge 1 commit into
base: master
from

Conversation

@aviyadeveloper
Copy link

@aviyadeveloper aviyadeveloper commented Feb 17, 2019

There's was an overlooked behavior inconsistency between the assignment of this.state.currentEnthusiasm assigment at the Hello component constructor and the expect behavior in the test 'throws when the enthusiasm level is 0'.

I fixed the assignment rather than the test itself so that the wanted behavior will work. When enthusiamLevel is 0 it will now actually throw and error instead of bypassing the falsy value and setting this.state.currentEnthusiasm to 1.

…teful Components + commentation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.