Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
add set log level handler for setting log level from vscode side. #47
Conversation
|
@andxu, |
...osoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/LogUtils.java
Outdated
| if (arguments != null && arguments.size() == 1 && arguments.get(0) instanceof String) { | ||
| try { | ||
| logger.setLevel(Level.parse((String) arguments.get(0))); | ||
| logger.warning(String.format("Set log level to : %s", arguments.get(0))); |
akaroml
Sep 25, 2017
Member
why is this a warning?
info is enough to tell the user the log level is set to whatever they specified.
why is this a warning?
info is enough to tell the user the log level is set to whatever they specified.
...osoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/LogUtils.java
Outdated
| logger.warning(String.format("Set log level to : %s", arguments.get(0))); | ||
| return logger.getLevel().toString(); | ||
| } catch (IllegalArgumentException e) { | ||
| logger.warning(String.format("Invalid log level: %s", arguments.get(0))); |
akaroml
Sep 25, 2017
Member
It should be an error.
It should be an error.
...osoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/LogUtils.java
Outdated
| } | ||
|
|
||
| } else { | ||
| logger.warning(String.format("Invalid parameters for configLogLevel: %s", StringUtils.join(arguments))); |
akaroml
Sep 25, 2017
Member
It should be an error.
It should be an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.