Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[suggestion] chore: add annotation typescript usage in README #136
Conversation
* recommend enabling `strict` mode for avoiding type checking failure
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 15 15
Lines 936 936
Branches 205 205
=======================================
Hits 920 920
Misses 16 16 Continue to review full report at Codecov.
|
|
Nice catch! I'm not sure why |
This commit intends to fix the issue reported on msgpack#136
This commit intends to fix the issue reported on msgpack#136
This commit intends to fix the issue reported on msgpack#136
About
recommend enabling
strictmode for avoiding type checking failure when using this library in TypeScript project.Background
As I mentioned in #135 , I found the circumstance where the type checking for encode/decode function call fails.
That specifically happens when user defined context type is given to the ExtensionCodec.
Solution
Set
compilerOptions.strictNullCheckstotrueintsconfig.json.Acknowledgement
I'm not so familiar with TypeScript and still don't understand why this issue happens. (I'll follow up this phenomenon for my interest later)