Why create empty settings file on the User folder? #144

evandrocoan · 2017-09-30T18:00:58Z

On the lines we can find it:

File: Data/Packages/SQLTools/SQLTools.py
665:     userSettingFile = os.path.join(sublimeUserFolder, SQLTOOLS_SETTINGS_FILE)
666:     if not os.path.isfile(userSettingFile):
667:         # create empty settings file in 'User' folder
668:         sublime.save_settings(SQLTOOLS_SETTINGS_FILE)

Above has the comment:

    # this ensures we have empty settings file in 'User' directory during first start
    # otherwise sublime will copy entire contents of 'SQLTools.sublime-settings'
    # which is not desirable and prevents future changes to queries and other
    # sensible defaults defined in settings file, as those would be overriden by content
    # from older versions of SQLTools in 'User\SQLTools.sublime-settings'

However I never saw Sublime Text doing such thing on version 3. Perhaps this is a fix Sublime Text version 2?

The text was updated successfully, but these errors were encountered:

tkopets · 2017-09-30T18:25:23Z

This change was introduced not that long ago and I think the above-mentioned Sublime Text behavior in that comment is still valid.
I believe I observed this at least on Sublime Text build 3126 - you can try to comment out or remove this line and take a look at the outcome yourself.

evandrocoan · 2019-01-07T13:53:17Z

I just tested, Sublime Text does not do that. This plugin does that:

File: Data/Packages/SQLTools/SQLToolsAPI/Storage.py
 8: class Storage:
 9:     def __init__(self, filename, default=None):
10:         self.storageFile = filename
11:         self.defaultFile = default
12:         self.items = {}
13: 
14:         # copy entire file, to keep comments
15:         if not os.path.isfile(filename) and default and os.path.isfile(default):
16:             shutil.copyfile(default, filename)

tkopets closed this Oct 24, 2017

evandrocoan mentioned this issue Jan 7, 2019

Stop creating settings #206

Merged

evandrocoan added a commit to evandrocoan/User that referenced this issue Jan 7, 2019

Deleted SQLTools.sublime-settings mtxr/SublimeText-SQLTools#144

814ae3d

tkopets mentioned this issue Jun 7, 2019

Release v0.9.12 #221

Merged

mtxr / SublimeText-SQLTools Archived

Why create empty settings file on the User folder? #144

Why create empty settings file on the User folder? #144

evandrocoan commented Sep 30, 2017 •

edited

tkopets commented Sep 30, 2017 •

edited

evandrocoan commented Jan 7, 2019

mtxr / SublimeText-SQLTools Archived

Why create empty settings file on the User folder? #144

Why create empty settings file on the User folder? #144

Comments

evandrocoan commented Sep 30, 2017 • edited

tkopets commented Sep 30, 2017 • edited

evandrocoan commented Jan 7, 2019

evandrocoan commented Sep 30, 2017 •

edited

tkopets commented Sep 30, 2017 •

edited