Floating two patches that have not yet landed upstream:

• https://chromium-review.googlesource.com/c/v8/v8/+/804554
  • Merge request: https://bugs.chromium.org/p/v8/issues/detail?id=7191
• https://chromium-review.googlesource.com/c/v8/v8/+/806774
  • Merge request: https://bugs.chromium.org/p/v8/issues/detail?id=7198

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

V8, build

CI: https://ci.nodejs.org/job/node-test-pull-request/11908/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1101/

Failures in the V8 CI looks related to a test runner change

08:07:26 run-tests.py: error: no such option: --noi18n

edit:

Benchmark machine is showing a different failure

07:52:29 In file included from ../src/setup-isolate-full.cc:7:
07:52:29 .././src/base/logging.h:8:10: fatal error: 'cstring' file not found
07:52:29 #include <cstring>
07:52:29          ^~~~~~~~~
07:52:29 In file included from ../src/base/cpu.cc:5:
07:52:29 In file included from .././src/base/cpu.h:16:
07:52:29 In file included from .././src/base/base-export.h:8:
07:52:29 .././include/v8config.h:16:11: fatal error: 'features.h' file not found
07:52:29 # include <features.h>
07:52:29           ^~~~~~~~~~~~
07:52:29 In file included from ../src/base/bits.cc:5:
07:52:29 .././src/base/bits.h:9:10: fatal error: 'type_traits' file not found
07:52:29 #include <type_traits>
07:52:29          ^~~~~~~~~~~~~
07:52:29 In file included from ../src/base/debug/stack_trace.cc:5:
07:52:29 .././src/base/debug/stack_trace.h:13:10: fatal error: 'iosfwd' file not found
07:52:29 #include <iosfwd>
07:52:29          ^~~~~~~~
07:52:29 1 error generated.
07:52:29 In file included from ../src/base/division-by-constant.cc:5:
07:52:29 In file included from .././src/base/division-by-constant.h:10:
07:52:29 In file included from .././src/base/base-export.h:8:
07:52:29 .././include/v8config.h:16:11: fatal error: 'features.h' file not found
07:52:29 # include <features.h>
07:52:29           ^~~~~~~~~~~~
07:52:29 make[2]: *** [/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out/x64.release/obj.target/v8_libbase/src/base/cpu.o] Error 1
07:52:29 make[2]: *** Waiting for unfinished jobs....

Windows failures are expected, we will no longer support VS2015 with the 6.4 release. We need to update CI to account for this

ARM failures are all infra related

/cc @nodejs/build for the benchmark failures that look gcc related

Rerunning Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/14092/