★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/17924Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline,test: update references to archived repository #17924

Closed
wants to merge 2 commits into from
Closed

readline,test: update references to archived repository #17924

wants to merge 2 commits into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Dec 31, 2017 •
edited

References to issues / PRs from the old repository (https://github.com/nodejs/node-v0.x-archive) are misleading without the full URL. Updated references within the test directory accordingly.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

readline, test

@tniessen tniessen changed the title test: update references to archived repository readline,test: update references to archived repository Dec 31, 2017
@maclover7
Copy link
Member

@maclover7 maclover7 commented Dec 31, 2017

Lite CI because it's only comments: https://ci.nodejs.org/job/node-test-pull-request-lite/57/

lpinca
lpinca approved these changes Jan 1, 2018
View changes
jasnell
jasnell approved these changes Jan 1, 2018
View changes
tniessen added a commit that referenced this issue Jan 3, 2018
@tniessen
test: update references to archived repository
8951fcf 
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
tniessen added a commit that referenced this issue Jan 3, 2018
@tniessen
readline: update references to archived repository
3b1e263 
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen
Copy link
Member Author

@tniessen tniessen commented Jan 3, 2018

Landed in 8951fcf, 3b1e263.

@tniessen tniessen closed this Jan 3, 2018
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Jan 9, 2018

Should this be backported to v9.x? It does not land cleanly

tniessen added a commit to tniessen/node that referenced this issue Jan 11, 2018
@tniessen
test: update references to archived repository
8097297 
PR-URL: nodejs#17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
tniessen added a commit to tniessen/node that referenced this issue Jan 11, 2018
@tniessen
readline: update references to archived repository
5c89060 
PR-URL: nodejs#17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen tniessen mentioned this pull request Jan 11, 2018
Closed
evanlucas added a commit that referenced this issue Jan 17, 2018
@tniessen @evanlucas
test: update references to archived repository
733df36 
Backport-PR-URL: #18102
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
evanlucas added a commit that referenced this issue Jan 17, 2018
@tniessen @evanlucas
readline: update references to archived repository
56a9ae7 
Backport-PR-URL: #18102
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Feb 27, 2018

Would we be able to get this change backported to v8.x and v6.x as well?

tniessen added a commit to tniessen/node that referenced this issue Mar 4, 2018
@tniessen
test: update references to archived repository
790553c 
PR-URL: nodejs#17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
tniessen added a commit to tniessen/node that referenced this issue Mar 4, 2018
@tniessen
readline: update references to archived repository
ef830c6 
PR-URL: nodejs#17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen tniessen mentioned this pull request Mar 4, 2018
Closed
tniessen added a commit to tniessen/node that referenced this issue Mar 4, 2018
@tniessen
test: update references to archived repository
d3fbbe0 
PR-URL: nodejs#17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
tniessen added a commit to tniessen/node that referenced this issue Mar 4, 2018
@tniessen
readline: update references to archived repository
d04ffa3 
PR-URL: nodejs#17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen tniessen mentioned this pull request Mar 4, 2018
Closed
MylesBorins added a commit that referenced this issue Mar 21, 2018
@tniessen @MylesBorins
test: update references to archived repository
b36330f 
Backport-PR-URL: #19119
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 21, 2018
@tniessen @MylesBorins
readline: update references to archived repository
2a0ed0e 
Backport-PR-URL: #19119
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 21, 2018
@tniessen @MylesBorins
test: update references to archived repository
45c69f6 
Backport-PR-URL: #19120
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 21, 2018
@tniessen @MylesBorins
readline: update references to archived repository
f341a00 
Backport-PR-URL: #19120
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 28, 2018
@tniessen @MylesBorins
test: update references to archived repository
ebd9a18 
Backport-PR-URL: #19120
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 28, 2018
@tniessen @MylesBorins
readline: update references to archived repository
096e4c6 
Backport-PR-URL: #19120
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 28, 2018
@tniessen @MylesBorins
test: update references to archived repository
790ef2f 
Backport-PR-URL: #19119
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 28, 2018
@tniessen @MylesBorins
readline: update references to archived repository
8c25003 
Backport-PR-URL: #19119
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 30, 2018
@tniessen @MylesBorins
test: update references to archived repository
f3c6feb 
Backport-PR-URL: #19120
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 30, 2018
@tniessen @MylesBorins
readline: update references to archived repository
72a5710 
Backport-PR-URL: #19120
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 30, 2018
@tniessen @MylesBorins
test: update references to archived repository
5155d8e 
Backport-PR-URL: #19119
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this issue Mar 30, 2018
@tniessen @MylesBorins
readline: update references to archived repository
965b56a 
Backport-PR-URL: #19119
PR-URL: #17924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
Merged
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@lpinca lpinca

@cjihrig cjihrig

@maclover7 maclover7

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
10 participants
@tniessen @maclover7 @MylesBorins @jasnell @addaleax @lpinca @cjihrig @BridgeAR @TimothyGu @nodejs-github-bot