★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/17988Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use smaller input file for test-zlib.js #17988

Closed
wants to merge 1 commit into from

Conversation

Copy link
Member

@Trott Trott commented Jan 5, 2018

Fixes: #17986

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott Trott added test zlib labels Jan 5, 2018
@nodejs-github-bot nodejs-github-bot added the test label Jan 5, 2018
@Trott
Copy link
Member Author

@Trott Trott commented Jan 5, 2018

ping @MylesBorins (who wrote this test case in 241eb6122ee)

@Trott Trott added the fast-track label Jan 5, 2018
@Trott
Copy link
Member Author

@Trott Trott commented Jan 5, 2018

jasnell pushed a commit that referenced this issue Jan 10, 2018
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell
Copy link
Member

@jasnell jasnell commented Jan 10, 2018

Landed in bf2e964

@jasnell jasnell closed this Jan 10, 2018
evanlucas pushed a commit that referenced this issue Jan 22, 2018
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas pushed a commit that referenced this issue Jan 30, 2018
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 27, 2018
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 27, 2018
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 27, 2018
@MylesBorins MylesBorins mentioned this pull request Feb 27, 2018
@Trott Trott deleted the reduce-mem-footprint branch Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track test zlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants