★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18018Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,test: fix spelling in comments #18018

Closed
wants to merge 3 commits into from
Closed

lib,test: fix spelling in comments #18018

wants to merge 3 commits into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jan 6, 2018 •
edited

Various spelling fixes. I am not sure whether to split this into multiple commits.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

lib, test

maclover7
maclover7 approved these changes Jan 6, 2018
View changes
Copy link
Member

@maclover7 maclover7 left a comment

LGTM

Personally, I'm fine with one large commit.

@tniessen tniessen changed the title test: fix spelling in test case comments lib,test: fix spelling in test case comments Jan 6, 2018
@tniessen tniessen changed the title lib,test: fix spelling in test case comments lib,test: fix spelling in comments Jan 6, 2018
apapirovski
apapirovski approved these changes Jan 6, 2018
View changes
Copy link
Member

@apapirovski apapirovski left a comment

SGTM! 👍

test/parallel/test-http-agent-keepalive.js Outdated
@@ -102,7 +102,7 @@ function remoteClose() {
}

function remoteError() {
// remove server will destroy ths socket
// remove server will destroy the socket
Copy link
Member

@apapirovski apapirovski Jan 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "remove" here is supposed to be "remote"?

Copy link
Member Author

@tniessen tniessen Jan 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh yeah sure, thanks!

test/parallel/test-http-extra-response.js Outdated
@@ -51,7 +51,7 @@ const server = net.createServer(function(socket) {

if (postBody.includes('\r\n')) {
socket.write(fullResponse);
// omg, I wrote the response twice, what a terrible HTTP server I am.
// I wrote the response twice, what a terrible HTTP server I am.
Copy link
Member

@apapirovski apapirovski Jan 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this comment adds much in general, to be honest. I would be in favour of taking it out.

test/parallel/test-promises-unhandled-rejections.js Outdated
@@ -293,7 +293,7 @@ asyncTest('While inside setImmediate, catching a rejected promise derived ' +
});
});

// State adapation tests
// State adaption tests
Copy link
Member

@apapirovski apapirovski Jan 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what this comment is saying (before or after). :( I think the tests describe what they do well enough.

(If we are to keep it, I would prefer to use the more common version "adaptation".)

Copy link
Member Author

@tniessen tniessen Jan 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand that test either, I went with "adaptation" for now. If someone knows what's going on here, we might actually remove it.

@tniessen
Copy link
Member Author

@tniessen tniessen commented Jan 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12438/

lpinca
lpinca approved these changes Jan 7, 2018
View changes
@tniessen tniessen force-pushed the fix-spelling-in-tests branch from d984a90 to 8fcc84d Compare Jan 7, 2018
jasnell
jasnell approved these changes Jan 7, 2018
View changes
cjihrig
cjihrig approved these changes Jan 7, 2018
View changes
hiroppy
hiroppy approved these changes Jan 8, 2018
View changes
@jasnell
Copy link
Member

@jasnell jasnell commented Jan 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12472/

@tniessen
Copy link
Member Author

@tniessen tniessen commented Jan 10, 2018

Seems like CI was interrupted, new CI: https://ci.nodejs.org/job/node-test-pull-request/12494/

tniessen added a commit that referenced this issue Jan 11, 2018
@tniessen
test: fix spelling in test case comments
e890344 
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
tniessen added a commit that referenced this issue Jan 11, 2018
@tniessen
lib: fix spelling in comments
ba07699 
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@tniessen
Copy link
Member Author

@tniessen tniessen commented Jan 11, 2018

Landed in e890344, ba07699.

@tniessen tniessen closed this Jan 11, 2018
evanlucas added a commit that referenced this issue Jan 30, 2018
@tniessen @evanlucas
test: fix spelling in test case comments
5fccb6e 
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
evanlucas added a commit that referenced this issue Jan 30, 2018
@tniessen @evanlucas
lib: fix spelling in comments
dcdb646 
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Feb 27, 2018

Should this be backported to v6.x-staging or v8.x-staging?? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

tniessen added a commit to tniessen/node that referenced this issue Mar 4, 2018
@tniessen
test: fix spelling in test case comments
dbf0618 
PR-URL: nodejs#18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
tniessen added a commit to tniessen/node that referenced this issue Mar 4, 2018
@tniessen
lib: fix spelling in comments
e335b55 
PR-URL: nodejs#18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@tniessen tniessen mentioned this pull request Mar 4, 2018
Closed
tniessen added a commit to tniessen/node that referenced this issue Mar 4, 2018
@tniessen
test: fix spelling in test case comments
8a95359 
PR-URL: nodejs#18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@tniessen tniessen mentioned this pull request Mar 4, 2018
Closed
MylesBorins added a commit that referenced this issue Mar 14, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
894b179 
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins added a commit that referenced this issue Mar 21, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
a52f4eb 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins added a commit that referenced this issue Mar 21, 2018
@tniessen @MylesBorins
lib: fix spelling in comments
8cbb164 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins added a commit that referenced this issue Mar 28, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
1196355 
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins added a commit that referenced this issue Mar 28, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
059a803 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins added a commit that referenced this issue Mar 28, 2018
@tniessen @MylesBorins
lib: fix spelling in comments
63b0de2 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins added a commit that referenced this issue Mar 30, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
502781c 
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins added a commit that referenced this issue Mar 30, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
1043b6f 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins added a commit that referenced this issue Mar 30, 2018
@tniessen @MylesBorins
lib: fix spelling in comments
3df0570 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
Merged
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski

@jasnell jasnell

@lpinca lpinca

@cjihrig cjihrig

@maclover7 maclover7

@hiroppy hiroppy

@starkwang starkwang

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet