doc: prefer make test-only when verifying the build #18061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
reviewed
Jan 9, 2018
| To verify the build: | ||
|
|
||
| ```console | ||
| $ make test-only |
There was a problem hiding this comment.
I am wondering if there is anyone out there using the existing make check (alias to make test) because to me make check sounds better than make test-only for that purpose.
jasnell
approved these changes
Jan 9, 2018
Fishrock123
approved these changes
Jan 9, 2018
XadillaX
approved these changes
Jan 10, 2018
lpinca
approved these changes
Jan 10, 2018
Trott
reviewed
Jan 10, 2018
BUILDING.md
Outdated
| $ make test-only | ||
| ``` | ||
|
|
||
| At this point you are ready to make code changes and re-run the tests. |
Trott
reviewed
Jan 10, 2018
BUILDING.md
Outdated
|
|
||
| ```console | ||
| $ make test | ||
| ``` | ||
|
|
||
| At this point you are ready to make code changes and re-run the tests! | ||
| Which also runs linters and the tests on the documentation. |
There was a problem hiding this comment.
Nit: Instead of Which also runs linters... maybe `make test` will run linters...
There was a problem hiding this comment.
I have changed this to
`make test` does a full check on the codebase, including running linters and
documentation tests.
so it's clearer about what it does.
danbev
approved these changes
Jan 11, 2018
|
Landed in e8c491a, thanks! |
joyeecheung
added a commit
that referenced
this issue
Jan 12, 2018
PR-URL: #18061 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
evanlucas
added a commit
that referenced
this issue
Jan 30, 2018
PR-URL: #18061 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
added a commit
that referenced
this issue
Feb 27, 2018
PR-URL: #18061 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc