★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18264Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: simplify src._readableState to state #18264

Closed
wants to merge 1 commit into from
Closed

stream: simplify src._readableState to state #18264

wants to merge 1 commit into from

Conversation

MoonBall
Copy link
Member

@MoonBall MoonBall commented Jan 20, 2018 •
edited

A small change.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

stream

lpinca
lpinca approved these changes Jan 20, 2018
View changes
targos
targos approved these changes Jan 20, 2018
View changes
@targos
Copy link
Member

@targos targos commented Jan 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12639/

@jasnell jasnell requested a review from mcollina Jan 22, 2018
mcollina
mcollina approved these changes Jan 22, 2018
View changes
Copy link
Member

@mcollina mcollina left a comment

LGTM

@starkwang
Copy link
Contributor

@starkwang starkwang commented Jan 30, 2018

CI before landing: https://ci.nodejs.org/job/node-test-pull-request-lite/137/

@starkwang
Copy link
Contributor

@starkwang starkwang commented Jan 30, 2018

Landed in 49b3798. Thanks for your contribution!

@starkwang starkwang closed this Jan 30, 2018
starkwang added a commit that referenced this issue Jan 30, 2018
@starkwang
stream: simplify src._readableState to state
49b3798 
PR-URL: #18264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas added a commit that referenced this issue Jan 30, 2018
@evanlucas
stream: simplify src._readableState to state
25bebae 
PR-URL: #18264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this issue Mar 20, 2018
@MylesBorins
stream: simplify src._readableState to state
be796e6 
PR-URL: #18264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this issue Mar 20, 2018
@MylesBorins
stream: simplify src._readableState to state
bef8d38 
PR-URL: #18264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this issue Mar 28, 2018
@MylesBorins
stream: simplify src._readableState to state
0f593be 
PR-URL: #18264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this issue Mar 28, 2018
@MylesBorins
stream: simplify src._readableState to state
b665068 
PR-URL: #18264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this issue Mar 30, 2018
@MylesBorins
stream: simplify src._readableState to state
64c83d7 
PR-URL: #18264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this issue Mar 30, 2018
@MylesBorins
stream: simplify src._readableState to state
bf52382 
PR-URL: #18264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
Merged
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova added a commit to MayaLekova/node that referenced this issue May 8, 2018
@MayaLekova
stream: simplify src._readableState to state
d68ca77 
PR-URL: nodejs#18264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina

@lpinca lpinca

@targos targos

@starkwang starkwang

Assignees
No one assigned
Labels
stream
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
7 participants
@MoonBall @targos @starkwang @mcollina @lpinca @MylesBorins @nodejs-github-bot