★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18286Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typo in in async_hooks.triggerAsyncId explanation #18286

Closed
wants to merge 1 commit into from

Conversation

Copy link
Contributor

@ramesius ramesius commented Jan 22, 2018

Tiny typo I found whilst reading through the async hooks documentation.
fom -> from

@nodejs-github-bot nodejs-github-bot added async_hooks doc labels Jan 22, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track label Jan 22, 2018
@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jan 22, 2018

vsemozhetbyt pushed a commit that referenced this issue Jan 22, 2018
Fix typo in `async_hooks.executionAsyncId()` explanation.

PR-URL: #18286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jan 22, 2018

Landed in 55a9375

Thank you, @ramesius!

evanlucas pushed a commit that referenced this issue Jan 30, 2018
Fix typo in `async_hooks.executionAsyncId()` explanation.

PR-URL: #18286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 27, 2018
Fix typo in `async_hooks.executionAsyncId()` explanation.

PR-URL: #18286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
Fix typo in `async_hooks.executionAsyncId()` explanation.

PR-URL: nodejs#18286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks doc fast-track
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants