benchmark: implement duration in http test double #18380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Jan 26, 2018
cjihrig
approved these changes
Jan 26, 2018
|
CI failures are unrelated. Landing.. |
|
Landed in 98d1110. Thanks! |
joyeecheung
added a commit
that referenced
this issue
Jan 29, 2018
PR-URL: #18380 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this issue
Jan 30, 2018
PR-URL: #18380 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Feb 27, 2018
PR-URL: #18380 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this issue
May 8, 2018
PR-URL: nodejs#18380 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When using the test double benchmarker the throughput would always be 1, which breaks the R script - that is fine, but it would be helpful to make it less dumb so we can start digging into the profile of our http benchmarks using this simplified benchmarker.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)