test: refactor test assertions and comments in napi tests #18414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireeshpunathil
approved these changes
Jan 28, 2018
lpinca
approved these changes
Jan 28, 2018
| assert.ok(test_general.testGetPrototype(baseObject) !== | ||
| test_general.testGetPrototype(extendedObject), | ||
| 'Prototypes for base and extended should be different'); | ||
| //Prototypes for base and extended should be different. |
There was a problem hiding this comment.
Nit: can you please add a space after //?
jasnell
approved these changes
Jan 29, 2018
BridgeAR
approved these changes
Jan 31, 2018
|
[Moderated] |
contact-natz
approved these changes
Jan 31, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this issue
Jan 31, 2018
PR-URL: nodejs#18414 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 6e312c5 |
|
|
MylesBorins
pushed a commit
that referenced
this issue
Feb 20, 2018
PR-URL: #18414 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this issue
Feb 21, 2018
PR-URL: #18414 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this issue
Feb 21, 2018
PR-URL: #18414 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this issue
Apr 12, 2018
PR-URL: nodejs#18414 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this issue
Apr 16, 2018
PR-URL: nodejs#18414 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this issue
May 8, 2018
PR-URL: nodejs#18414 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change
assert.ok()toassert.notStrictEquals()where appropriate and change some functions to arrow functions.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes