doc: nodejs/modules team now exists #18545
Conversation
|
There is |
|
@targos will these two teams be consolidated or kept separate? (what should i do with this pr) |
|
I don't know. If the people of the new team are all OK to be cc'd for every module issue or PR in core, we can remove nodejs/esm |
|
cc @nodejs/esm are you in favor of merging @nodejs/esm into @nodejs/modules ? BTW we can also make @nodejs/esm a child team of @nodejs/modules if people don't want to be cc'd for other module issues, although given that we want to make ESM interoperable with CJS modules, most issues of CJS modules also need to be considered by ESM and the fixes should be kept in sync whenever reasonable. |
|
I'm cool with getting pinged for all things module (cjs/esm/node/wasm) |
|
I'm probably not understanding what I'm getting into :-), but for me getting cc-ed on every module issue/PR would actually be a great way to get into things quickly. |
doc/onboarding-extras.md
Outdated
| @@ -31,7 +31,7 @@ | |||
| | `test/*` | @nodejs/testing | | |||
| | `tools/node_modules/eslint`, `.eslintrc` | @not-an-aardvark, @silverwind, @trott | | |||
| | build | @nodejs/build | | |||
| | ES Modules | @bmeck, @Fishrock123, @guybedford, @MylesBorins, @targos | | |||
| | ES Modules | @nodejs/modules | | |||
There was a problem hiding this comment.
If we are talking about all things module...maybe this can be more specific, e.g. putting it down as lib/{internal/}module.js and src/module_wrap.*?
|
Mini-CI https://ci.nodejs.org/job/node-test-commit-light/211/ @devsnek would you be so kind and always trigger a CI after opening a PR? :-) |
|
@BridgeAR can i do that yet? i haven't actually joined as a node collab yet, ci page doesn't show anything to let me start a run. |
|
Oh, I see. In that case no. I thought that would already be the case. |
|
Landed in 9686d87 |
Mention the new modules team. PR-URL: nodejs#18545 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Mention the new modules team. PR-URL: #18545 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Mention the new modules team. PR-URL: #18545 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Mention the new modules team. PR-URL: #18545 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Mention the new modules team. PR-URL: nodejs#18545 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
the nodejs/modules team has been created, changes who to ping for es modules
Checklist
Affected core subsystem(s)