★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18694Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: provide proper deprecation code #18694

Closed
wants to merge 1 commit into from
Closed

async_hooks: provide proper deprecation code #18694

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Feb 10, 2018

Refs: #18513

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_hooks

@BridgeAR BridgeAR requested a review from ofrobots Feb 10, 2018
@BridgeAR
Copy link
Member Author

@BridgeAR BridgeAR commented Feb 10, 2018

CI https://ci.nodejs.org/job/node-test-commit-light/249/

ofrobots
ofrobots approved these changes Feb 10, 2018
View changes
Copy link
Contributor

@ofrobots ofrobots left a comment

This needs a rebase. The commit 5febd8b LGTM.

Thanks for catching this.

cjihrig
cjihrig approved these changes Feb 10, 2018
View changes
Copy link
Contributor

@cjihrig cjihrig left a comment

LGTM with the first five commits rebased out.

@ofrobots ofrobots mentioned this pull request Feb 10, 2018
Merged
3 tasks
@BridgeAR
Copy link
Member Author

@BridgeAR BridgeAR commented Feb 10, 2018

Done. Sorry for the mess.

lpinca
lpinca approved these changes Feb 11, 2018
View changes
@BridgeAR
Copy link
Member Author

@BridgeAR BridgeAR commented Feb 12, 2018 •
edited

Landed in ba944b1

@BridgeAR BridgeAR closed this Feb 12, 2018
BridgeAR added a commit to BridgeAR/node that referenced this issue Feb 12, 2018
@BridgeAR
lib: provide proper deprecation code
ba944b1 
Refs: nodejs#18513

PR-URL: nodejs#18694
Refs: nodejs#18513
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ofrobots added a commit to ofrobots/node that referenced this issue Feb 21, 2018
@BridgeAR @ofrobots
lib: provide proper deprecation code
78c2409 
Refs: nodejs#18513

PR-URL: nodejs#18694
Refs: nodejs#18513
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ofrobots ofrobots mentioned this pull request Feb 21, 2018
Closed
2 tasks
MylesBorins added a commit that referenced this issue Feb 21, 2018
@BridgeAR @MylesBorins
lib: provide proper deprecation code
664a681 
Refs: #18513

Backport-PR-URL: #18892
PR-URL: #18694
Refs: #18513
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this issue Feb 21, 2018
@BridgeAR @MylesBorins
lib: provide proper deprecation code
cc1df6d 
Refs: #18513

Backport-PR-URL: #18892
PR-URL: #18694
Refs: #18513
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins added a commit that referenced this issue Feb 21, 2018
@BridgeAR @MylesBorins
lib: provide proper deprecation code
0a97e1d 
Refs: #18513

Backport-PR-URL: #18892
PR-URL: #18694
Refs: #18513
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ofrobots ofrobots mentioned this pull request Mar 21, 2018
Merged
4 tasks
MayaLekova added a commit to MayaLekova/node that referenced this issue May 8, 2018
@BridgeAR @MayaLekova
lib: provide proper deprecation code
028acd3 
Refs: nodejs#18513

PR-URL: nodejs#18694
Refs: nodejs#18513
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ofrobots added a commit to ofrobots/node that referenced this issue Jun 28, 2018
@BridgeAR @ofrobots
lib: provide proper deprecation code
9065e08 
Refs: nodejs#18513

Backport-PR-URL: nodejs#19517
PR-URL: nodejs#18694
Refs: nodejs#18513
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg added a commit that referenced this issue Aug 16, 2018
@BridgeAR @rvagg
lib: provide proper deprecation code
7e23946 
Refs: #18513

Backport-PR-URL: #19517
PR-URL: #18694
Refs: #18513
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR deleted the fix-dep branch Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots

@Fishrock123 Fishrock123

@lpinca lpinca

@cjihrig cjihrig

Assignees
No one assigned
Labels
async_hooks author ready fast-track
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
7 participants
@BridgeAR @ofrobots @Fishrock123 @lpinca @cjihrig @MylesBorins @nodejs-github-bot