★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18747Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: stricter no-multiple-empty-lines rule #18747

Closed
wants to merge 1 commit into from
Closed

doc: stricter no-multiple-empty-lines rule #18747

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Feb 13, 2018

This reduces the maximum line number in the no-multiple-empty-lines eslint rule to 1 for the docs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@BridgeAR
doc: activate no-multiple-empty-lines rule
2c5cf8e 
This enables the `no-multiple-empty-lines` eslint rule for the docs.
@nodejs-github-bot nodejs-github-bot added doc vm labels Feb 13, 2018
@BridgeAR
Copy link
Member Author

@BridgeAR BridgeAR commented Feb 13, 2018

Light-CI https://ci.nodejs.org/job/node-test-commit-light/260/

@BridgeAR BridgeAR added author ready blocked and removed author ready labels Feb 13, 2018
@BridgeAR
Copy link
Member Author

@BridgeAR BridgeAR commented Feb 13, 2018

Blocked by #18758

@BridgeAR BridgeAR added author ready and removed blocked labels Feb 16, 2018
@BridgeAR
Copy link
Member Author

@BridgeAR BridgeAR commented Feb 16, 2018

New CI rebased to origin/master https://ci.nodejs.org/job/node-test-commit-light/277/

@BridgeAR
Copy link
Member Author

@BridgeAR BridgeAR commented Feb 16, 2018

Landed in 69f7ce9

@BridgeAR BridgeAR closed this Feb 16, 2018
BridgeAR added a commit to BridgeAR/node that referenced this issue Feb 16, 2018
@BridgeAR
doc: activate no-multiple-empty-lines rule
69f7ce9 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: nodejs#18747
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
a14186b 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
c569f70 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
cd2fa04 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@BridgeAR @MayaLekova
doc: activate no-multiple-empty-lines rule
c956636 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: nodejs#18747
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins pushed a commit that referenced this issue Aug 7, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
b4fa857 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins pushed a commit that referenced this issue Aug 7, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
4e2241e 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins pushed a commit that referenced this issue Aug 7, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
e7cccf3 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins pushed a commit that referenced this issue Aug 9, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
6cd23c2 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this issue Aug 16, 2018
@BridgeAR @MylesBorins
doc: activate no-multiple-empty-lines rule
ebd73ad 
This enables the `no-multiple-empty-lines` eslint rule for the docs.

PR-URL: #18747
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@BridgeAR BridgeAR deleted the no-multiline-docs branch Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@lpinca lpinca

@cjihrig cjihrig

@mmarchini mmarchini

@starkwang starkwang

Assignees
No one assigned
Labels
author ready doc vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@BridgeAR @jasnell @lpinca @cjihrig @mmarchini @starkwang @MylesBorins @nodejs-github-bot