@nodejs/testing @nodejs/build

An argument could be made to also clear out the other environment variables. Or maybe allow them to be set but print out a warning that test results may be affected.

@richardlau hm, how about we do both, warn them that test results may get affected if env variables are set. use --unset-env-variables flag to unset all the variables that might affect test o/p?

@richardlau hm, how about we do both, warn them that test results may get affected if env variables are set. use --unset-env-variables flag to unset all the variables that might affect test o/p?

Sounds quite complicated, I'd just unset this one by default for now, and do other things as we need to. If there are reasons to have NODE_OPTIONS set when running the test, we could just introduce an alternative variable like NODE_TEST_OPTIONS, but again I wouldn't do that unless it's necessary.

If you want to unset all of them I guess that's fine, but leaving it until someone runs into a problem seems reasonable too.

@gibfahn yep, complicated. i guess we can land this pr as is then? and if we run into some problem in future we can come with some other solution

CI https://ci.nodejs.org/job/node-test-pull-request/14423/

Landed in 5af28c2 🎉