★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/20544Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused freelist.h header #20544

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@bnoordhuis bnoordhuis

@danbev danbev

@jasnell jasnell

@TimothyGu TimothyGu

@cjihrig cjihrig

@mmarchini mmarchini

Assignees
No one assigned
Labels
C++ author ready land-on-v8.x lib / src
Projects
None yet
Milestone
No milestone
8 participants
@addaleax @bnoordhuis @danbev @jasnell @TimothyGu @cjihrig @mmarchini @nodejs-github-bot
@addaleax
Copy link
Member

addaleax commented May 5, 2018

Always easy enough to re-introduce if we do need it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@addaleax
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
22439dd

@nodejs-github-bot nodejs-github-bot added the C++ label May 5, 2018

@addaleax addaleax added the lib / src label May 5, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

addaleax commented May 5, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14674/
@cjihrig

cjihrig approved these changes May 5, 2018
View changes

@addaleax addaleax added the author ready label May 5, 2018

@bnoordhuis

bnoordhuis approved these changes May 6, 2018
View changes

@jasnell

jasnell approved these changes May 6, 2018
View changes

@danbev

danbev approved these changes May 7, 2018
View changes

@mmarchini

mmarchini approved these changes May 7, 2018
View changes

@TimothyGu

TimothyGu approved these changes May 7, 2018
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

addaleax commented May 9, 2018

Landed in 5bb5d61

@addaleax addaleax closed this May 9, 2018

@addaleax addaleax deleted the addaleax:no-freelist branch May 9, 2018

addaleax added a commit that referenced this pull request May 9, 2018

@addaleax
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: #20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
5bb5d61

devsnek added a commit to devsnek/node that referenced this pull request May 9, 2018

@addaleax @devsnek
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: nodejs#20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Verified
This commit was signed with a verified signature.
@devsnek devsnek Gus Caplan
GPG key ID: F00BD11880E82F0E Learn about signing commits
3a07138

targos added a commit that referenced this pull request May 12, 2018

@addaleax @targos
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: #20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
4873fba

shisama added a commit to shisama/node that referenced this pull request May 13, 2018

@addaleax @shisama
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: nodejs#20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
2c54ab7

shisama added a commit to shisama/node that referenced this pull request May 13, 2018

@addaleax @shisama
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: nodejs#20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
dc164ca

@addaleax addaleax referenced this pull request May 14, 2018

Merged

v10.2.0 proposal #20724

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@addaleax @shisama
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: nodejs#20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
6dfa10e

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@addaleax @shisama
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: nodejs#20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
38cceca

shisama added a commit to shisama/node that referenced this pull request Jun 5, 2018

@addaleax @shisama
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: nodejs#20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
847c318

shisama added a commit to shisama/node that referenced this pull request Jun 9, 2018

@addaleax @shisama
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: nodejs#20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
bca9f9d

shisama added a commit to shisama/node that referenced this pull request Jun 11, 2018

@addaleax @shisama
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: nodejs#20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
98fd69b

shisama added a commit to shisama/node that referenced this pull request Jun 12, 2018

@addaleax @shisama
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: nodejs#20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
84e5494

shisama added a commit to shisama/node that referenced this pull request Jun 17, 2018

@addaleax @shisama
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: nodejs#20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
73a9743

addaleax added a commit that referenced this pull request Jun 29, 2018

@addaleax
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: #20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
0a76327

@addaleax addaleax added the land-on-v8.x label Jun 29, 2018

@MylesBorins MylesBorins referenced this pull request Jul 9, 2018

Merged

v8.12.0 proposal #21593

rvagg added a commit that referenced this pull request Aug 16, 2018

@addaleax @rvagg
src: remove unused freelist.h header 
Always easy enough to re-introduce if we do need it.

PR-URL: #20544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
1cb9772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.