★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/20779Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: throw when entry point is null #20779

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@cjihrig cjihrig

Assignees
No one assigned
Labels
C++ backported-to-v8.x dont-land-on-v6.x n-api
Projects
None yet
Milestone
No milestone
5 participants
@gabrielschulhof @MylesBorins @addaleax @cjihrig @nodejs-github-bot
@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented May 16, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added C++ dont-land-on-v4.x dont-land-on-v6.x n-api labels May 16, 2018

@gabrielschulhof gabrielschulhof referenced this pull request May 16, 2018

Closed

src: add addon entry point symbol cache #20759

3 of 3 tasks complete
@cjihrig

cjihrig approved these changes May 16, 2018
View changes

@addaleax

addaleax approved these changes May 16, 2018
View changes

Copy link
Member

addaleax left a comment

Would be nice to use node_errors.h for this, though.

@gabrielschulhof gabrielschulhof force-pushed the gabrielschulhof:n-api-handle-null-init branch from f33d2a1 to 99fa5a7 May 16, 2018

@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented May 16, 2018

@addaleax I've changed the text of the error message to be exactly the same as the text for regular addons, i.e. "Module has no declared entry point."

Can we replace both with a node_errors.h construction without the result being semver-major?
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented May 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15027/

@gabrielschulhof gabrielschulhof force-pushed the gabrielschulhof:n-api-handle-null-init branch from 99fa5a7 to a2097c7 May 23, 2018

@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented May 23, 2018

Fixed lint. CI: https://ci.nodejs.org/job/node-test-pull-request/15068/
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented May 24, 2018

The CI failures are unrelated.
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented May 24, 2018

Landed in 9a02de7.

@gabrielschulhof gabrielschulhof closed this May 24, 2018

gabrielschulhof added a commit that referenced this pull request May 24, 2018

@gabrielschulhof
n-api: throw when entry point is null 
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9a02de7

@gabrielschulhof gabrielschulhof deleted the gabrielschulhof:n-api-handle-null-init branch May 24, 2018

targos added a commit that referenced this pull request May 25, 2018

@gabrielschulhof @targos
n-api: throw when entry point is null 
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
ba30d14

@MylesBorins MylesBorins referenced this pull request May 29, 2018

Merged

v10.3.0 proposal #21011

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@gabrielschulhof @shisama
n-api: throw when entry point is null 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9401a7a

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@gabrielschulhof @shisama
n-api: throw when entry point is null 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
e8d0fde

shisama added a commit to shisama/node that referenced this pull request Jun 5, 2018

@gabrielschulhof @shisama
n-api: throw when entry point is null 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
4b54046

shisama added a commit to shisama/node that referenced this pull request Jun 9, 2018

@gabrielschulhof @shisama
n-api: throw when entry point is null 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aafe76a

shisama added a commit to shisama/node that referenced this pull request Jun 11, 2018

@gabrielschulhof @shisama
n-api: throw when entry point is null 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
f3d5661

shisama added a commit to shisama/node that referenced this pull request Jun 12, 2018

@gabrielschulhof @shisama
n-api: throw when entry point is null 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
f4612ad

shisama added a commit to shisama/node that referenced this pull request Jun 17, 2018

@gabrielschulhof @shisama
n-api: throw when entry point is null 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1195ee6

@mhdawson mhdawson referenced this pull request Jul 4, 2018

Merged

v8.12.0 proposal #21593

@MylesBorins MylesBorins added the backport-requested-v8.x label Jul 9, 2018

@MylesBorins

This comment has been minimized.

Sign in to view
Copy link
Member

MylesBorins commented Jul 9, 2018

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Jul 10, 2018

@gabrielschulhof
n-api: throw when entry point is null 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
10b195e

@gabrielschulhof gabrielschulhof referenced this pull request Jul 10, 2018

Closed

[v8.x-backport] n-api: throw when entry point is null #21732

0 of 4 tasks complete

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Jul 14, 2018

@gabrielschulhof
n-api: throw when entry point is null 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
d4e5de2

MylesBorins added a commit that referenced this pull request Aug 1, 2018

@gabrielschulhof @MylesBorins
n-api: throw when entry point is null 
Backport-PR-URL: #21732
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
b48791d

@MylesBorins MylesBorins added backported-to-v8.x and removed backport-requested-v8.x labels Aug 1, 2018

rvagg added a commit that referenced this pull request Aug 16, 2018

@gabrielschulhof @rvagg
n-api: throw when entry point is null 
Backport-PR-URL: #21732
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
7033bba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.