★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/20970Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update tools/doc/package-lock.json #20970

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@lpinca lpinca

@joyeecheung joyeecheung

@trivikr trivikr

Assignees
No one assigned
Labels
author ready doc tools
Projects
None yet
Milestone
No milestone
5 participants
@Trott @joyeecheung @lpinca @trivikr @nodejs-github-bot
@Trott
Copy link
Member

Trott commented May 25, 2018 •
edited

The package-lock.json file is out of sync with the checked-in
node_modules. make doc-only updates package-lock.json appropriately.

Checklist

@nodejs-github-bot nodejs-github-bot added doc tools labels May 25, 2018

@Trott
tools: update tools/doc/package-lock.json 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.
Loading status checks…
9887c7c

@Trott Trott force-pushed the Trott:chore branch from 2933d7b to 9887c7c May 25, 2018

@lpinca

lpinca approved these changes May 26, 2018
View changes

@trivikr

trivikr approved these changes May 26, 2018
View changes

@joyeecheung

joyeecheung approved these changes May 27, 2018
View changes

@Trott Trott referenced this pull request May 28, 2018

Closed

test: show actual assertion error message with value #20956

2 of 2 tasks complete
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member

joyeecheung commented May 28, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/759/

@joyeecheung joyeecheung added the author ready label May 28, 2018

@Trott Trott referenced this pull request May 29, 2018

Closed

tools: ensure doc-only doesn't update package-lock #21015

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented May 29, 2018

Landed in 148b8ad

@Trott Trott closed this May 29, 2018

Trott added a commit to Trott/io.js that referenced this pull request May 29, 2018

@Trott
tools: update tools/doc/package-lock.json 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.

PR-URL: nodejs#20970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
148b8ad

MylesBorins added a commit that referenced this pull request May 29, 2018

@Trott @MylesBorins
tools: update tools/doc/package-lock.json 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.

PR-URL: #20970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
b62cbe1

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@Trott @shisama
tools: update tools/doc/package-lock.json 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.

PR-URL: nodejs#20970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
732f14c

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@Trott @shisama
tools: update tools/doc/package-lock.json 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.

PR-URL: nodejs#20970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
473249e

shisama added a commit to shisama/node that referenced this pull request Jun 5, 2018

@Trott @shisama
tools: update tools/doc/package-lock.json 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.

PR-URL: nodejs#20970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
dabca02

shisama added a commit to shisama/node that referenced this pull request Jun 9, 2018

@Trott @shisama
tools: update tools/doc/package-lock.json 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.

PR-URL: nodejs#20970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
c421f46

shisama added a commit to shisama/node that referenced this pull request Jun 11, 2018

@Trott @shisama
tools: update tools/doc/package-lock.json 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.

PR-URL: nodejs#20970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
8656f4a

shisama added a commit to shisama/node that referenced this pull request Jun 12, 2018

@Trott @shisama
tools: update tools/doc/package-lock.json 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.

PR-URL: nodejs#20970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2650e04

shisama added a commit to shisama/node that referenced this pull request Jun 17, 2018

@Trott @shisama
tools: update tools/doc/package-lock.json 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.

PR-URL: nodejs#20970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
f84036b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.