Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uphttp2: graduate from experimental #22466
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
dont-land-on-v6.x
http2
labels
Aug 23, 2018
jasnell
added
the
semver-minor
label
Aug 23, 2018
jasnell
requested a review
from nodejs/tsc
Aug 23, 2018
TimothyGu
approved these changes
Aug 23, 2018
|
|
cjihrig
approved these changes
Aug 23, 2018
ofrobots
approved these changes
Aug 23, 2018
trivikr
approved these changes
Aug 23, 2018
|
Yay!!!!! |
mcollina
added
the
dont-land-on-v8.x
label
Aug 23, 2018
This comment has been minimized.
This comment has been minimized.
|
I've added a dont-land-on-v8.x label because http2 on 8 is still far behind. This is not meant to be definitive, but it depends on those commits being backported. Feel free to remove once the two implementations are on par. |
lpinca
approved these changes
Aug 23, 2018
BridgeAR
approved these changes
Aug 23, 2018
tniessen
approved these changes
Aug 23, 2018
This comment has been minimized.
This comment has been minimized.
jasnell
added
the
author ready
label
Aug 23, 2018
ChALkeR
reviewed
Aug 24, 2018
| @@ -2,8 +2,6 @@ | |||
|
|
|||
| <!--introduced_in=v8.4.0--> | |||
This comment has been minimized.
This comment has been minimized.
ChALkeR
Aug 24, 2018
•
Member
The docs state when a module was introduced, but do not state when it was introduced out of experimental.
Any ideas how to improve this? /cc @nodejs/documentation
This is not blocking this PR from landing and it shouldn't depend on it, that is more like a related issue.
This comment has been minimized.
This comment has been minimized.
jasnell
Aug 24, 2018
Author
Member
Should likely include it in the per-section changelog. I can update this to do so
ChALkeR
approved these changes
Aug 24, 2018
apapirovski
approved these changes
Aug 24, 2018
joyeecheung
approved these changes
Aug 24, 2018
This comment has been minimized.
This comment has been minimized.
|
#22486 needs to be merged before the release. |
This comment has been minimized.
This comment has been minimized.
|
#22486 is not blocking in terms of landing this PR. It should land within the next couple of days, however, and should make it into the next 10.x release |
This comment has been minimized.
This comment has been minimized.
|
@jasnell That's what I said :P |
jasnell
force-pushed the
jasnell:http2-graduate
branch
from
6b4d060
to
9581322
Aug 24, 2018
jasnell
added
the
notable-change
label
Aug 25, 2018
jasnell
added a commit
that referenced
this pull request
Aug 25, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in 5d210d4!!! |

jasnell commentedAug 23, 2018
It's time.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes