★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24458Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix missing PR id #24458

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@lpinca lpinca

@targos targos

@richardlau richardlau

@vsemozhetbyt vsemozhetbyt

Assignees
No one assigned
Labels
author ready deprecations doc dont-land-on-v10.x dont-land-on-v8.x fast-track
Projects
  
Don't land (ever) in v11.x
Milestone
No milestone
6 participants
@oyyd @nodejs-github-bot @vsemozhetbyt @lpinca @targos @richardlau
@oyyd
Copy link
Contributor

commented Nov 18, 2018

Refs: #23329

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@oyyd
doc: fix missing PR id of 23329
Loading status checks…
6279e5d
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 18, 2018

@oyyd sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added deprecations doc labels Nov 18, 2018

@richardlau

richardlau approved these changes Nov 18, 2018
View changes

@targos

targos approved these changes Nov 18, 2018
View changes

@vsemozhetbyt

vsemozhetbyt approved these changes Nov 18, 2018
View changes

@vsemozhetbyt vsemozhetbyt added the author ready label Nov 18, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Nov 18, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1650/
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Nov 18, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
@lpinca

lpinca approved these changes Nov 18, 2018
View changes

@oyyd oyyd added the fast-track label Nov 18, 2018

@oyyd

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Nov 18, 2018

Landed in 34eccb2. Thanks!

@oyyd oyyd closed this Nov 18, 2018

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Nov 18, 2018

@oyyd
doc: fix missing PR id of 23329 
PR-URL: nodejs#24458
Refs: nodejs#23329
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
34eccb2

@targos targos added dont-land-on-v6.x dont-land-on-v8.x dont-land-on-v10.x labels Nov 19, 2018

@targos targos added this to Don't land (ever) in v11.x Nov 20, 2018

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@oyyd @refack
doc: fix missing PR id of 23329 
PR-URL: nodejs#24458
Refs: nodejs#23329
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
4fb2da8

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open

@beevelop beevelop referenced this pull request Apr 23, 2019

Open

2019-04-23 Version 12.0.0 (Current) @BethGriggs #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.