★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25091Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing pr-url #25091

Closed
wants to merge 1 commit into from
Closed

doc: add missing pr-url #25091

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Dec 17, 2018

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1982/pipeline

@nodejs-github-bot nodejs-github-bot added doc tls labels Dec 17, 2018
@sam-github
Copy link
Contributor

@sam-github sam-github commented Dec 17, 2018

Thanks for fixing this for me.

Could be fast-tracked.

@vsemozhetbyt vsemozhetbyt added fast-track author ready labels Dec 17, 2018
@Trott
Copy link
Member

@Trott Trott commented Dec 17, 2018

Landed in 928f776

@Trott Trott closed this Dec 17, 2018
Trott pushed a commit to Trott/io.js that referenced this issue Dec 17, 2018
@cjihrig @Trott
doc: add missing pr-url
928f776 
PR-URL: nodejs#25091
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@cjihrig cjihrig deleted the link branch Dec 19, 2018
@targos targos added this to Don't land (ever) in v11.x Dec 28, 2018
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@cjihrig @refack
doc: add missing pr-url
e90a917 
PR-URL: nodejs#25091
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau

@vsemozhetbyt vsemozhetbyt

Assignees
No one assigned
Labels
author ready doc fast-track tls
Projects
No open projects
v11.x
  
Don't land (ever)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cjihrig @nodejs-github-bot @sam-github @Trott @richardlau @vsemozhetbyt @MylesBorins @BethGriggs