★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25097Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove test-related GYP files #25097

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@danbev danbev

@jasnell jasnell

@watilde watilde

@richardlau richardlau

@ryzokuken ryzokuken

Assignees
No one assigned
Labels
V8 Engine author ready build dont-land-on-v10.x dont-land-on-v8.x
Projects
  
Don't land (ever) in v11.x
Milestone
No milestone
8 participants
@targos @nodejs-github-bot @danbev @jasnell @watilde @richardlau @ryzokuken @Trott
@targos
Copy link
Member

commented Dec 17, 2018

  • Less files to maintain.
  • We don't use them.
  • We build with GN to run V8 tests.

Fixes: #25095
Refs: #25010

/cc @ryzokuken
@targos
deps: remove test-related GYP files 
- Less files to maintain.
- We don't use them.
- We build with GN to run V8 tests.

Fixes: #25095
Refs: #25010
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
7ef5ff5
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the V8 Engine label Dec 17, 2018

@targos targos added the build label Dec 17, 2018

@richardlau

richardlau approved these changes Dec 17, 2018
View changes

@targos

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 17, 2018 •
edited by Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/19629/ ✔️
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1942/

@Trott Trott added the author ready label Dec 18, 2018

@danbev

danbev approved these changes Dec 18, 2018
View changes

@jasnell

jasnell approved these changes Dec 18, 2018
View changes

@watilde

watilde approved these changes Dec 18, 2018
View changes

@ryzokuken

ryzokuken approved these changes Dec 18, 2018
View changes

Copy link
Member

left a comment

Great PR! Thanks, @targos.
@targos

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 20, 2018

Landed in f0e4609

@targos targos closed this Dec 20, 2018

@targos targos deleted the targos:v8-gyp-no-tests branch Dec 20, 2018

targos added a commit that referenced this pull request Dec 20, 2018

@targos
deps: remove test-related GYP files 
- Less files to maintain.
- We don't use them.
- We build with GN to run V8 tests.

Fixes: #25095
Refs: #25010

PR-URL: #25097
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
f0e4609

@targos targos added dont-land-on-v6.x dont-land-on-v8.x dont-land-on-v10.x labels Dec 22, 2018

@targos targos added this to Don't land (ever) in v11.x Dec 28, 2018

@bnoordhuis bnoordhuis referenced this pull request Jan 8, 2019

Closed

alpha-sort sourcepaths in v8/unittests.gyp #25010

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@targos @refack
deps: remove test-related GYP files 
- Less files to maintain.
- We don't use them.
- We build with GN to run V8 tests.

Fixes: nodejs#25095
Refs: nodejs#25010

PR-URL: nodejs#25097
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
5ad4f19

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed

This was referenced Apr 23, 2019

Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.