★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25434Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix deprecations metadata #25434

Merged
merged 1 commit into from Jan 10, 2019
Merged

doc: fix deprecations metadata #25434

merged 1 commit into from Jan 10, 2019

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Jan 10, 2019

Refs: #25377

cc @cjihrig

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jan 10, 2019

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2223/pipeline

@nodejs-github-bot nodejs-github-bot added deprecations doc labels Jan 10, 2019
cjihrig
cjihrig approved these changes Jan 10, 2019
View changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Ugh, sorry! LGTM

@richardlau richardlau added the author ready label Jan 10, 2019
@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jan 10, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@richardlau richardlau added the fast-track label Jan 10, 2019
@richardlau
Copy link
Member Author

@richardlau richardlau commented Jan 10, 2019

Non-Blue Ocean link for the bot-started CI to satisfy node-core-utils:
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2223/

@richardlau
doc: fix deprecations metadata
ccf37b3 
Refs: nodejs#25377

PR-URL: nodejs#25434
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@richardlau richardlau self-assigned this Jan 10, 2019
@richardlau richardlau merged commit ccf37b3 into nodejs:master Jan 10, 2019
2 checks passed
@targos targos added this to Don't land (ever) in v11.x Jan 30, 2019
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig

@vsemozhetbyt vsemozhetbyt

Assignees

@richardlau richardlau

Labels
author ready deprecations doc fast-track
Projects
No open projects
v11.x
  
Don't land (ever)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@richardlau @nodejs-github-bot @vsemozhetbyt @cjihrig @addaleax