★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25934Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused method in env.h #25934

Closed
wants to merge 1 commit into from
Closed

src: remove unused method in env.h #25934

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 5, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@gengjiawen
src: remove unused method in env.h
e393804 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@nodejs-github-bot nodejs-github-bot added the c++ label Feb 5, 2019
@gengjiawen
Copy link
Member Author

@gengjiawen gengjiawen commented Feb 6, 2019

@addaleax Also this one, thanks.

@danbev
Copy link
Member

@danbev danbev commented Feb 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20659/

@lpinca
Copy link
Member

@lpinca lpinca commented Feb 9, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20683/

@lpinca
Copy link
Member

@lpinca lpinca commented Feb 9, 2019

Landed in c2d374f.

@lpinca lpinca closed this Feb 9, 2019
lpinca pushed a commit that referenced this issue Feb 9, 2019
@gengjiawen @lpinca
src: remove unused method in env.h
c2d374f 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25934
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Feb 10, 2019
Closed
@targos targos added this to Don't land (ever) in v11.x Feb 10, 2019
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@lpinca lpinca

Assignees
No one assigned
Labels
c++
Projects
No open projects
v11.x
  
Don't land (ever)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gengjiawen @danbev @lpinca @jasnell @addaleax @targos @nodejs-github-bot