★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26251Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix deprecation "End-of-Life" capitalization #26251

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@Trott Trott

@lpinca lpinca

@cjihrig cjihrig

@richardlau richardlau

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready deprecations doc dont-land-on-v10.x dont-land-on-v8.x
Projects
  
Don't land (ever) in v11.x
Milestone
No milestone
9 participants
@tniessen @nodejs-github-bot @Trott @cjihrig @richardlau @jasnell @lpinca @BridgeAR @addaleax
@tniessen
Copy link
Member

commented Feb 21, 2019

There are 78 occurrences of End-of-Life and two occurrences of End-Of-Life.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@tniessen
doc: fix deprecation "End-of-Life" capitalization
Verified
This commit was signed with a verified signature.
tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
Loading status checks…
1ad2cf5
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added deprecations doc labels Feb 21, 2019

@richardlau

richardlau approved these changes Feb 21, 2019
View changes

@BridgeAR

BridgeAR approved these changes Feb 21, 2019
View changes

@BridgeAR BridgeAR added the author ready label Feb 21, 2019

@Trott

Trott approved these changes Feb 21, 2019
View changes

Copy link
Member

left a comment •
edited

LGTM. Might be good to add End-Of-Life to https://github.com/Trott/remark-preset-lint-node/blob/594048a86e09993ead132df1c499fee05a239bce/index.js#L49-L55 to keep it from creeping back in.
@cjihrig

cjihrig approved these changes Feb 21, 2019
View changes

Copy link
Contributor

left a comment

LGTM, and agree with @Trott's idea.
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Feb 21, 2019

LGTM, and agree with @Trott's idea.

Once this lands, I'm happy to do it, but a PR is of course welcome!
@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Feb 21, 2019

I thought it would make the most sense as part of this PR, but yea, it can be separate too.

richardlau added a commit to richardlau/remark-preset-lint-node that referenced this pull request Feb 22, 2019

@richardlau
add End-Of-Life to prohibited strings 
Refs: nodejs/node#26251
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
2f5b83e

@richardlau richardlau referenced this pull request Feb 22, 2019

Merged

add End-Of-Life to prohibited strings #12

@richardlau

This comment has been minimized.

Sign in to view
Copy link
Member

commented Feb 22, 2019

LGTM. Might be good to add End-Of-Life to https://github.com/Trott/remark-preset-lint-node/blob/594048a86e09993ead132df1c499fee05a239bce/index.js#L49-L55 to keep it from creeping back in.

Since this was easy enough to do in GitHub's web UI editor: nodejs/remark-preset-lint-node#12

BridgeAR added a commit to nodejs/remark-preset-lint-node that referenced this pull request Feb 22, 2019

@richardlau @BridgeAR
add End-Of-Life to prohibited strings 
Refs: nodejs/node#26251
510655f
@lpinca

lpinca approved these changes Feb 23, 2019
View changes

@jasnell

jasnell approved these changes Feb 23, 2019
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Feb 23, 2019

Landed in 7e0ddf6

@Trott Trott closed this Feb 23, 2019

Trott added a commit to Trott/io.js that referenced this pull request Feb 23, 2019

@tniessen @Trott
doc: fix deprecation "End-of-Life" capitalization 
PR-URL: nodejs#26251
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
7e0ddf6

Trott added a commit to Trott/io.js that referenced this pull request Feb 23, 2019

@Trott
tools: update markdown linter 
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a
prohibited string, favoring `End-of-Life` for consistency.

Refs: nodejs#26251
e2bc015

@Trott Trott referenced this pull request Feb 23, 2019

Closed

tools: update markdown linter #26281

2 of 2 tasks complete

@addaleax addaleax added dont-land-on-v8.x dont-land-on-v10.x dont-land-on-v11.x labels Feb 25, 2019

Trott added a commit to Trott/io.js that referenced this pull request Feb 26, 2019

@Trott
tools: update markdown linter 
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a
prohibited string, favoring `End-of-Life` for consistency.

Refs: nodejs#26251

PR-URL: nodejs#26281
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ccd6b12

addaleax added a commit that referenced this pull request Mar 1, 2019

@Trott @addaleax
tools: update markdown linter 
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a
prohibited string, favoring `End-of-Life` for consistency.

Refs: #26251

PR-URL: #26281
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
0080350

@targos targos added this to Don't land (ever) in v11.x Mar 7, 2019

This was referenced Apr 23, 2019

Closed
Closed

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.