★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26278Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: allow deriving public from private keys #26278

Closed
wants to merge 2 commits into from
+79 −26

Conversation

Reviewers

@panva panva

@BridgeAR BridgeAR

@sam-github sam-github

@bnoordhuis bnoordhuis

@jasnell jasnell

Assignees
No one assigned
Labels
C++ author ready backported-to-v11.x crypto semver-minor
Projects
  
Backported in v11.x
Milestone
No milestone
8 participants
@tniessen @sam-github @panva @bnoordhuis @jasnell @BridgeAR @targos @nodejs-github-bot
@tniessen
Copy link
Member

tniessen commented Feb 23, 2019

This change allows passing private key objects to crypto.createPublicKey(), resulting in a KeyObject that represents a valid public key for the given private key. The returned public KeyObject can be used and exported safely without revealing information about the private key.

cc @sam-github, we talked about this in person and via Hangouts.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@tniessen
crypto: allow deriving public from private keys 
This change allows passing private key objects to
crypto.createPublicKey, resulting in a key object that represents a
valid public key for the given private key. The returned public key
object can be used and exported safely without revealing information
about the private key.
Verified
This commit was signed with a verified signature.
@tniessen tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
Loading status checks…
67f2fe8

@nodejs-github-bot nodejs-github-bot added C++ crypto labels Feb 23, 2019

@tniessen tniessen added the semver-minor label Feb 23, 2019

@nodejs nodejs deleted a comment from nodejs-github-bot Feb 23, 2019

@jasnell

jasnell approved these changes Feb 23, 2019
View changes

@bnoordhuis

bnoordhuis approved these changes Feb 24, 2019
View changes

@sam-github

sam-github approved these changes Feb 25, 2019
View changes

Copy link
Member

sam-github left a comment

Approved with some minor comments, address as you see fit.
Show resolved Hide resolved doc/api/crypto.md
Show resolved Hide resolved lib/internal/crypto/keys.js
@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Mar 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21159/

@tniessen tniessen added the author ready label Mar 4, 2019

@BridgeAR

BridgeAR reviewed Mar 5, 2019
View changes

Show resolved Hide resolved doc/api/crypto.md Outdated
@BridgeAR @tniessen
Update doc/api/crypto.md 
Co-Authored-By: tniessen <tniessen@users.noreply.github.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
73cb9a2
@panva

panva reviewed Mar 5, 2019
View changes

Show resolved Hide resolved doc/api/crypto.md

tniessen added a commit that referenced this pull request Mar 5, 2019

@tniessen
crypto: allow deriving public from private keys 
This change allows passing private key objects to
crypto.createPublicKey, resulting in a key object that represents a
valid public key for the given private key. The returned public key
object can be used and exported safely without revealing information
about the private key.

PR-URL: #26278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Verified
This commit was signed with a verified signature.
@tniessen tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
Loading status checks…
fe71629
@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Mar 5, 2019

Thanks for reviewing, everyone, landed in fe71629!

@sam-github, I know you are busy and that #26278 (comment) and #26278 (comment) are still open, but I think they can be addressed after landing this :)

@tniessen tniessen closed this Mar 5, 2019

@tniessen tniessen referenced this pull request Mar 5, 2019

Closed

crypto: simplify GetPublicOrPrivateKeyFromJs #26454

2 of 2 tasks complete

@tniessen tniessen referenced this pull request Mar 15, 2019

Closed

(v11.x backport) crypto: improve error handling in parseKeyEncoding #26688

@targos targos added the backported-to-v11.x label Mar 27, 2019

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@tniessen @targos
crypto: allow deriving public from private keys 
This change allows passing private key objects to
crypto.createPublicKey, resulting in a key object that represents a
valid public key for the given private key. The returned public key
object can be used and exported safely without revealing information
about the private key.

Backport-PR-URL: nodejs#26688
PR-URL: nodejs#26278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
ff03e61

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@tniessen @targos
crypto: allow deriving public from private keys 
This change allows passing private key objects to
crypto.createPublicKey, resulting in a key object that represents a
valid public key for the given private key. The returned public key
object can be used and exported safely without revealing information
about the private key.

Backport-PR-URL: nodejs#26688
PR-URL: nodejs#26278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
0be6f95

targos added a commit that referenced this pull request Mar 27, 2019

@tniessen @targos
crypto: allow deriving public from private keys 
This change allows passing private key objects to
crypto.createPublicKey, resulting in a key object that represents a
valid public key for the given private key. The returned public key
object can be used and exported safely without revealing information
about the private key.

Backport-PR-URL: #26688
PR-URL: #26278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
ed7599b

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

@targos targos added this to Backported in v11.x Mar 27, 2019

targos added a commit that referenced this pull request Mar 28, 2019

@targos
2019-03-28, Version 11.13.0 (Current) 
Notable changes:

* crypto
  * Allow deriving public from private keys (Tobias Nießen)
    [#26278](#26278).
* events
  * Added a `once` function to use `EventEmitter` with promises
    (Matteo Collina) [#26078](#26078).
* tty
  * Added a `hasColors` method to `WriteStream` (Ruben Bridgewater)
    [#26247](#26247).
  * Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater)
    [#26485](#26485).
* v8
  * Added `v8.getHeapSnapshot` and `v8.writeHeapSnapshot` to generate snapshots
    in the format used by tools such as Chrome DevTools (James M Snell)
    [#26501](#26501).
* worker
  * Added `worker.moveMessagePortToContext`. This enables using MessagePorts in
    different vm.Contexts, aiding with the isolation that the vm module seeks to
    provide (Anna Henningsen)
    [#26497](#26497).
* C++ API
  * `AddPromiseHook` is now deprecated. This API was added to fill an use case
    that is served by `async_hooks`, since that has `Promise` support
    (Anna Henningsen) [#26529](#26529).
  * Added a `Stop` API to shut down Node.js while it is running
    (Gireesh Punathil) [#21283](#21283).
* meta
  * [Gireesh Punathil](https://github.com/gireeshpunathil) is now a member of
    the Technical Steering Committee
    [#26657](#26657).
  * Added [Yongsheng Zhang](https://github.com/ZYSzys) to collaborators
    [#26730](#26730).

PR-URL: #26949
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
29867f3

targos added a commit that referenced this pull request Mar 28, 2019

@targos
2019-03-28, Version 11.13.0 (Current) 
Notable changes:

* crypto
  * Allow deriving public from private keys (Tobias Nießen)
    [#26278](#26278).
* events
  * Added a `once` function to use `EventEmitter` with promises
    (Matteo Collina) [#26078](#26078).
* tty
  * Added a `hasColors` method to `WriteStream` (Ruben Bridgewater)
    [#26247](#26247).
  * Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater)
    [#26485](#26485).
* v8
  * Added `v8.getHeapSnapshot` and `v8.writeHeapSnapshot` to generate snapshots
    in the format used by tools such as Chrome DevTools (James M Snell)
    [#26501](#26501).
* worker
  * Added `worker.moveMessagePortToContext`. This enables using MessagePorts in
    different vm.Contexts, aiding with the isolation that the vm module seeks to
    provide (Anna Henningsen)
    [#26497](#26497).
* C++ API
  * `AddPromiseHook` is now deprecated. This API was added to fill an use case
    that is served by `async_hooks`, since that has `Promise` support
    (Anna Henningsen) [#26529](#26529).
  * Added a `Stop` API to shut down Node.js while it is running
    (Gireesh Punathil) [#21283](#21283).
* meta
  * [Gireesh Punathil](https://github.com/gireeshpunathil) is now a member of
    the Technical Steering Committee
    [#26657](#26657).
  * Added [Yongsheng Zhang](https://github.com/ZYSzys) to collaborators
    [#26730](#26730).

PR-URL: #26949
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
2c73868

BethGriggs added a commit that referenced this pull request Apr 5, 2019

@targos @BethGriggs
2019-03-28, Version 11.13.0 (Current) 
Notable changes:

* crypto
  * Allow deriving public from private keys (Tobias Nießen)
    [#26278](#26278).
* events
  * Added a `once` function to use `EventEmitter` with promises
    (Matteo Collina) [#26078](#26078).
* tty
  * Added a `hasColors` method to `WriteStream` (Ruben Bridgewater)
    [#26247](#26247).
  * Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater)
    [#26485](#26485).
* v8
  * Added `v8.getHeapSnapshot` and `v8.writeHeapSnapshot` to generate snapshots
    in the format used by tools such as Chrome DevTools (James M Snell)
    [#26501](#26501).
* worker
  * Added `worker.moveMessagePortToContext`. This enables using MessagePorts in
    different vm.Contexts, aiding with the isolation that the vm module seeks to
    provide (Anna Henningsen)
    [#26497](#26497).
* C++ API
  * `AddPromiseHook` is now deprecated. This API was added to fill an use case
    that is served by `async_hooks`, since that has `Promise` support
    (Anna Henningsen) [#26529](#26529).
  * Added a `Stop` API to shut down Node.js while it is running
    (Gireesh Punathil) [#21283](#21283).
* meta
  * [Gireesh Punathil](https://github.com/gireeshpunathil) is now a member of
    the Technical Steering Committee
    [#26657](#26657).
  * Added [Yongsheng Zhang](https://github.com/ZYSzys) to collaborators
    [#26730](#26730).

PR-URL: #26949
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
473b162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.