★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26492Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: assign missed deprecation code #26492

Closed
wants to merge 1 commit into from
Closed

lib: assign missed deprecation code #26492

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 7, 2019

Refs: #26245

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 7, 2019

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2798/pipeline

@addaleax
Copy link
Member Author

@addaleax addaleax commented Mar 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21300/

Please 👍 this comment to approve fast-tracking.

@targos targos added this to Don't land (ever) in v11.x Mar 7, 2019
cjihrig
cjihrig approved these changes Mar 7, 2019
View changes
@addaleax
Copy link
Member Author

@addaleax addaleax commented Mar 7, 2019

Landed in 76e67e9

@addaleax addaleax closed this Mar 7, 2019
@addaleax addaleax deleted the dep00125 branch Mar 7, 2019
addaleax added a commit that referenced this issue Mar 7, 2019
@addaleax
lib: assign missed deprecation code
76e67e9 
Refs: #26245

PR-URL: #26492
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig

@richardlau richardlau

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
deprecations fast-track lib / src
Projects
No open projects
v11.x
  
Don't land (ever)
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
7 participants
@addaleax @nodejs-github-bot @cjihrig @richardlau @gireeshpunathil @BridgeAR @vsemozhetbyt