★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26821Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION #26821

Closed
wants to merge 1 commit into from
Closed

doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION #26821

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Mar 20, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@sam-github sam-github added tls doc labels Mar 20, 2019
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 20, 2019

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2989/pipeline

@sam-github
Copy link
Contributor Author

@sam-github sam-github commented Mar 20, 2019

ci: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2994/

@BridgeAR BridgeAR added the author ready label Mar 25, 2019
@sam-github
Copy link
Contributor Author

@sam-github sam-github commented Mar 25, 2019

Landed in d989e20

@sam-github sam-github closed this Mar 25, 2019
sam-github added a commit that referenced this issue Mar 25, 2019
@sam-github
doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION
d989e20 
PR-URL: #26821
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this issue Mar 26, 2019
@sam-github @BethGriggs
doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION
0791e3c 
PR-URL: #26821
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos
Copy link
Member

@targos targos commented Mar 28, 2019

IIUC this should land with or after #26951

@sam-github sam-github deleted the doc-default-max-min branch Mar 29, 2019
@sam-github
Copy link
Contributor Author

@sam-github sam-github commented Mar 29, 2019

will cherry pick onto the backport for tls1.3

@sam-github sam-github mentioned this pull request Mar 29, 2019
Closed
4 tasks
sam-github added a commit to sam-github/node that referenced this issue Apr 1, 2019
@sam-github
doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION
1a6436d 
PR-URL: nodejs#26821
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
sam-github added a commit to sam-github/node that referenced this issue Apr 11, 2019
@sam-github
doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION
6589fe1 
PR-URL: nodejs#26821
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this issue Apr 15, 2019
@sam-github @BethGriggs
doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION
fa6f0f1 
Backport-PR-URL: #26951
PR-URL: #26821
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Apr 19, 2019
Merged
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@Trott
Copy link
Member

@Trott Trott commented Jul 18, 2019

This looks like it went out in 11.15.0, so I'm going to change backport-requested-v11.x label for backported-to-v11.x label. Hope that's the right thing to do.

@Trott
Copy link
Member

@Trott Trott commented Jul 18, 2019

Looks like DEFAULT_MIN_VERSION was in 10.16.0 but no documentation is in 10.16.0 for it. Does this need a v10.x backport? Cherry-pick? Neither? @sam-github @BethGriggs

@Trott Trott mentioned this pull request Jul 18, 2019
Closed
@Trott
Copy link
Member

@Trott Trott commented Jul 18, 2019

(Refs: #28758. That should be closed once this is in 10.x-staging, I suppose.)

@sam-github
Copy link
Contributor Author

@sam-github sam-github commented Jul 22, 2019

@nitinsurana do you have time to backport the 11.x version of this, fa6f0f1, to 10.x? It would be fairly straight-forward, but all references to TLSv1.3 would have to be removed.

I added the various labels, but don't know when this will hit the top of my TODO list.

@nitinsurana
Copy link

@nitinsurana nitinsurana commented Jul 23, 2019

@sam-github Sure; let me give it a try.

ckarande added a commit to ckarande/node that referenced this issue Jul 23, 2019
@ckarande
doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION
e3ebd51 
Add documentation for tls.DEFAULT_MAX_VERSION and
tls.DEFAULT_MIN_VERSION, which existed in v10.6.0

Fixes: nodejs#28758
Refs: nodejs#26821
@ckarande ckarande mentioned this pull request Jul 23, 2019
Closed
3 tasks
BethGriggs pushed a commit that referenced this issue Oct 7, 2019
@ckarande @BethGriggs
doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION
cef5010 
Add documentation for tls.DEFAULT_MAX_VERSION and
tls.DEFAULT_MIN_VERSION, which existed in v10.6.0

Fixes: #28758
Refs: #26821

PR-URL: #28827
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this issue Oct 7, 2019
@ckarande @BethGriggs
doc: fix the links tls default version sections
c285e69 
PR-URL: #28827
Fixes: #28758
Refs: #26821
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis

@jasnell jasnell

@cjihrig cjihrig

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready doc tls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sam-github @nodejs-github-bot @targos @Trott @nitinsurana @bnoordhuis @jasnell @cjihrig @BridgeAR