★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27056Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test vm.runInNewContext() filename option #27056

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@lpinca lpinca

@cjihrig cjihrig

@devsnek devsnek

@BethGriggs BethGriggs

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready test
Projects
None yet
Milestone
No milestone
8 participants
@bnoordhuis @nodejs-github-bot @danbev @lpinca @cjihrig @devsnek @BethGriggs @BridgeAR
@bnoordhuis
Copy link
Member

commented Apr 2, 2019

The 'filename as a string' case was already being tested. This commit
also exercises the 'filename as an option' case.
@bnoordhuis
test: test vm.runInNewContext() filename option 
The 'filename as a string' case was already being tested. This commit
also exercises the 'filename as an option' case.
Loading status checks…
f215ae0
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 2, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3144

@nodejs-github-bot nodejs-github-bot added the test label Apr 2, 2019

@lpinca

lpinca approved these changes Apr 2, 2019
View changes

@cjihrig

cjihrig approved these changes Apr 2, 2019
View changes

@BethGriggs

BethGriggs approved these changes Apr 2, 2019
View changes

@BridgeAR

BridgeAR approved these changes Apr 3, 2019
View changes

@BridgeAR BridgeAR added the author ready label Apr 3, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22140/
@devsnek

devsnek approved these changes Apr 3, 2019
View changes

@bnoordhuis

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 3, 2019

New CI, the last one ran into infrastructure problems: https://ci.nodejs.org/job/node-test-pull-request/22168/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22168/
@bnoordhuis

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 4, 2019

The failure is #26910.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22193/
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 5, 2019

Landed in f13733d.

@danbev danbev closed this Apr 5, 2019

danbev added a commit that referenced this pull request Apr 5, 2019

@bnoordhuis @danbev
test: test vm.runInNewContext() filename option 
The 'filename as a string' case was already being tested. This commit
also exercises the 'filename as an option' case.

PR-URL: #27056
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Loading status checks…
f13733d

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.