★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27071Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise Collaborator description in GOVERNANCE.md #27071

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Apr 3, 2019

  • Active voice
  • Remove Node.js Foundation mention. It may be appropriate to add
    something back in when the new foundation is bootstrapped. We
    don't control membership criteria, so best to link to something else
    when it becomes available rather than make guarantees in this doc.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
doc: revise Collaborator description in GOVERNANCE.md 
* Active voice
* Remove Node.js Foundation mention. It may be appropriate to add
  something back in when the new foundation is bootstrapped. We
  don't control membership criteria, so best to link to something else
  when it becomes available rather than make guarantees in this doc.
Loading status checks…
9d488b9
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 3, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3154

@nodejs-github-bot nodejs-github-bot added the meta label Apr 3, 2019

@antsmartian
antsmartian approved these changes Apr 3, 2019
View changes

@Trott Trott added the author ready label Apr 3, 2019

@vsemozhetbyt
vsemozhetbyt approved these changes Apr 3, 2019
View changes
@lpinca
lpinca approved these changes Apr 3, 2019
View changes
@richardlau
richardlau approved these changes Apr 3, 2019
View changes
@ZYSzys
ZYSzys approved these changes Apr 4, 2019
View changes
@jasnell
jasnell approved these changes Apr 4, 2019
View changes
@hiroppy
hiroppy approved these changes Apr 4, 2019
View changes
@mhdawson
mhdawson approved these changes Apr 4, 2019
View changes
Copy link
Member

left a comment

LGTM
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 5, 2019

Landed in 181052d

@Trott Trott closed this Apr 5, 2019

Trott added a commit to Trott/io.js that referenced this pull request Apr 5, 2019
@Trott
doc: revise Collaborator description in GOVERNANCE.md 
* Active voice
* Remove Node.js Foundation mention. It may be appropriate to add
  something back in when the new foundation is bootstrapped. We
  don't control membership criteria, so best to link to something else
  when it becomes available rather than make guarantees in this doc.

PR-URL: nodejs#27071
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
181052d
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@antsmartian antsmartian

@lpinca lpinca

@hiroppy hiroppy

@richardlau richardlau

@mhdawson mhdawson

@vsemozhetbyt vsemozhetbyt

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready meta
Projects
None yet
Milestone
No milestone
10 participants
@Trott @nodejs-github-bot @jasnell @antsmartian @lpinca @hiroppy @richardlau @mhdawson @vsemozhetbyt @ZYSzys
You can’t perform that action at this time.