★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27075Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix section sorting, add link reference #27075

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@lpinca lpinca

Assignees
No one assigned
Labels
doc errors fast-track
Projects
None yet
Milestone
No milestone
4 participants
@vsemozhetbyt @nodejs-github-bot @addaleax @lpinca
@vsemozhetbyt
Copy link
Contributor

commented Apr 3, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

After #27037, system errors section is unified with other class sections, so it should be placed between Class: SyntaxError and Class: TypeError sections.

Also, a missing bottom reference is added with the new URL.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 3, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3158

@nodejs-github-bot nodejs-github-bot added the doc label Apr 3, 2019

@vsemozhetbyt vsemozhetbyt added the errors label Apr 3, 2019

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Apr 3, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
@addaleax

addaleax approved these changes Apr 3, 2019
View changes

@lpinca

lpinca approved these changes Apr 3, 2019
View changes

@vsemozhetbyt vsemozhetbyt added the fast-track label Apr 3, 2019

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Apr 3, 2019

Landed in 10eaf6a
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt closed this Apr 3, 2019

vsemozhetbyt added a commit that referenced this pull request Apr 3, 2019

@vsemozhetbyt
doc: fix section sorting, add link reference 
PR-URL: #27075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Loading status checks…
10eaf6a

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-errors-nits branch Apr 3, 2019

BethGriggs added a commit that referenced this pull request Apr 4, 2019

@vsemozhetbyt @BethGriggs
doc: fix section sorting, add link reference 
PR-URL: #27075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
3bad808

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.