stream: remove dead code #27125
Closed
stream: remove dead code #27125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unreachable code. `state.ended` is always set to true in this part of the code. The `else` clause can't be executed.
addaleax
approved these changes
Apr 7, 2019
BridgeAR
approved these changes
Apr 7, 2019
ZYSzys
approved these changes
Apr 8, 2019
cjihrig
approved these changes
Apr 8, 2019
jasnell
approved these changes
Apr 8, 2019
tniessen
approved these changes
Apr 9, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this issue
Apr 10, 2019
Remove unreachable code. `state.ended` is always set to true in this part of the code. The `else` clause can't be executed. PR-URL: nodejs#27125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in 1a67c99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRemoved unreachable code. In line
511,state.endedis set totrue. Soprocess.nextTick(emitReadable_, stream);can't be reached.