★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27137Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,report: improve signal name validation #27137

Merged
merged 2 commits into from Apr 11, 2019
Merged

lib,report: improve signal name validation #27137

merged 2 commits into from Apr 11, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 8, 2019

  • Add a signal name validator to enforce type and check for known signals.
  • Improve error message when the signal name casing is incorrect.
  • Use the new validator in the report module.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 8, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3200

@nodejs-github-bot nodejs-github-bot added the process label Apr 8, 2019
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22284/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 9, 2019 •
edited by cjihrig

CI: https://ci.nodejs.org/job/node-test-pull-request/22286/

EDIT(cjihrig): 💚

@BridgeAR BridgeAR added the author ready label Apr 9, 2019
cjihrig added 2 commits Apr 11, 2019
@cjihrig
lib: add signal name validator
5b9e570 
PR-URL: nodejs#27137
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@cjihrig
report: improve signal name validation
44a3acb 
PR-URL: nodejs#27137
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@cjihrig
Copy link
Contributor Author

@cjihrig cjihrig commented Apr 11, 2019

Landed in 72f4a83...44a3acb. Thanks for the reviews.

@cjihrig cjihrig closed this Apr 11, 2019
@cjihrig cjihrig deleted the signal-validate branch Apr 11, 2019
@cjihrig cjihrig merged commit 44a3acb into nodejs:master Apr 11, 2019
1 of 2 checks passed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis

@Fishrock123 Fishrock123

@richardlau richardlau

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cjihrig @nodejs-github-bot @bnoordhuis @Fishrock123 @richardlau @BridgeAR