★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27146Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: enforce the use of Object from primordials #27146

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@bnoordhuis bnoordhuis

@jasnell jasnell

@addaleax addaleax

@cjihrig cjihrig

@joyeecheung joyeecheung

@devsnek devsnek

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready lib / src
Projects
None yet
Milestone
No milestone
@targos
Copy link
Member

commented Apr 9, 2019

No description provided.

@targos
lib: enforce the use of Object from primordials
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
36e494d
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 9, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3206

@nodejs-github-bot nodejs-github-bot added the lib / src label Apr 9, 2019

@cjihrig

cjihrig approved these changes Apr 9, 2019
View changes

Copy link
Contributor

left a comment

LGTM if the CI passes.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22290/
@BridgeAR

BridgeAR approved these changes Apr 9, 2019
View changes

@joyeecheung

joyeecheung approved these changes Apr 9, 2019
View changes

@BridgeAR BridgeAR added the author ready label Apr 9, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22292/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22293/
@bnoordhuis

bnoordhuis approved these changes Apr 9, 2019
View changes

@addaleax

addaleax approved these changes Apr 9, 2019
View changes

@jasnell

jasnell approved these changes Apr 10, 2019
View changes

@devsnek

devsnek approved these changes Apr 10, 2019
View changes

@joyeecheung joyeecheung referenced this pull request Apr 10, 2019

Closed

lib: create primordials in every context #27171

2 of 2 tasks complete
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 12, 2019

Landed in 908292c.

@danbev danbev closed this Apr 12, 2019

danbev added a commit that referenced this pull request Apr 12, 2019

@targos @danbev
lib: enforce the use of Object from primordials 
PR-URL: #27146
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Loading status checks…
908292c

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@trptcolin

This comment has been minimized.

Sign in to view
Copy link

commented May 18, 2019

I just wanted to say thank you for this fix! 🙇 ❤️ Much appreciated.

Bumped up against this issue on an older node version due to a userspace monkey-patch (of Object.defineProperty in an ES5 shim from one of our dependencies, and I'm glad to see someone's already done the hard work of solving the underlying issue. Thanks!

@targos targos deleted the targos:primordial-object branch May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.