Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: add missing n-api version indicator #27155
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
doc
n-api
labels
Apr 9, 2019
cjihrig
approved these changes
Apr 9, 2019
richardlau
approved these changes
Apr 9, 2019
jasnell
approved these changes
Apr 10, 2019
richardlau
added
the
author ready
label
Apr 10, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in |
mhdawson
closed this
Apr 11, 2019
mhdawson
added a commit
that referenced
this pull request
Apr 11, 2019
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mhdawson commentedApr 9, 2019
When the threadsafe functions were promoted to
version 4 from experimental we missed documenting
that. Add the version indicator for these functions
in the doc.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes