★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27193Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark some known flakes #27193

Merged
merged 1 commit into from Apr 11, 2019
+5 −0

Conversation

Reviewers

@Trott Trott

@richardlau richardlau

Assignees
No one assigned
Labels
CI / flaky test fast-track test
Projects
None yet
Milestone
No milestone
4 participants
@refack @nodejs-github-bot @Trott @richardlau
@refack
Copy link
Member

commented Apr 11, 2019 •
edited

Refs: #20750
Refs: #26610

@nodejs/testing PTAL

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 11, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3233

@nodejs-github-bot nodejs-github-bot added the test label Apr 11, 2019

@refack refack added CI / flaky test fast-track labels Apr 11, 2019

@refack

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 11, 2019

I move this should be fast tracked, please 👍 here if you concur.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 11, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22377/
@Trott

Trott approved these changes Apr 11, 2019
View changes

@richardlau

richardlau approved these changes Apr 11, 2019
View changes

@refack
test: mark some known flakes 
PR-URL: #27193
Refs: #20750
Refs: #26610
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Loading status checks…
abe4183

@refack refack force-pushed the refack:mark-some-flakes branch from 4808bf1 to abe4183 Apr 11, 2019

@refack

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 11, 2019

Fast tracking with 2 up-votes
image

@refack refack merged commit abe4183 into nodejs:master Apr 11, 2019
1 of 2 checks passed

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@refack refack deleted the refack:mark-some-flakes branch Apr 11, 2019

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.