test: fix test-dns-idna2008.js #27208
Conversation
The test should pass if ESERVFAIL is the result. Refs: nodejs#25870 (comment)
|
Custom CI to run |
|
Did this fail on CI? Because that indicates a wonkey system DNS setup. (It's a nice canary, but not a healthy situation in any other respect). |
Yes, it failed in CI, but only showed up as yellow rather than red, which was something I was going to ask about. https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/6132/ 00:01:57 not ok 9 internet/test-dns-idna2008
00:01:57 ---
00:01:57 duration_ms: 1.413
00:01:57 severity: fail
00:01:57 exitcode: 1
00:01:57 stack: |-
00:01:57 /home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/common/index.js:681
00:01:57 const crashOnUnhandledRejection = (err) => { throw err; };
00:01:57 ^
00:01:57
00:01:57 Error: queryA ESERVFAIL straße.de
00:01:57 at QueryReqWrap.onresolve [as oncomplete] (internal/dns/promises.js:167:17)
00:01:57 ... |
Should have been red. There was a bug in the CI config were it interpreted return value of 1 as |
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/jobConfigHistory/showDiffFiles?timestamp1=2019-04-09_11-24-54×tamp2=2019-04-13_13-13-15 reintroduces skipping the test (e.g. on 8.x) causing the job to fail, i.e. it undoes part of #26933 (comment) |
Good eye! Also added a comment. Hopefully I'll see it (also 2 should be more eyebrow raising then 1) |
|
Landed in f6bd3b2 |
The test should pass if ESERVFAIL is the result. Refs: nodejs#25870 (comment) PR-URL: nodejs#27208 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The test should pass if ESERVFAIL is the result.
Refs: #25870 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes