★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27225Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark some known flakes #27225

Merged
merged 0 commits into from Apr 21, 2019
Merged

test: mark some known flakes #27225

merged 0 commits into from Apr 21, 2019

Conversation

@refack
Copy link
Member

@refack refack commented Apr 14, 2019 •
edited

Refs: #26910 - test-tls-sni-option: PASS,FLAKY
Refs: #27219 - test-tls-sni-server-client: PASS,FLAKY
Refs: #26938 - test-tls-js-stream: PASS,FLAKY
Refs: #23089 - test-gc-http-client-onerror: PASS,FLAKY

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 14, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3247

@refack
Copy link
Member Author

@refack refack commented Apr 14, 2019

/CC @nodejs/testing @nodejs/crypto

Please 👍 if you approve of fast-tracking this.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22432/

lpinca
lpinca approved these changes Apr 17, 2019
View changes
ZYSzys
ZYSzys approved these changes Apr 21, 2019
View changes
@refack refack closed this Apr 21, 2019
@refack refack force-pushed the more-flakes-oooffff branch from ed1c999 to 528d100 Apr 21, 2019
@refack refack deleted the more-flakes-oooffff branch Apr 21, 2019
@refack refack added the landed label Apr 21, 2019
@refack refack merged commit 528d100 into nodejs:master Apr 21, 2019
1 check passed
@refack
Copy link
Member Author

@refack refack commented Apr 21, 2019

Landed in 528d100

@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
MylesBorins added a commit that referenced this issue May 16, 2019
@refack @MylesBorins
test: mark some known flakes
915ea2a 
PR-URL: #27225
Refs: #26910
Refs: #27219
Refs: #26938
Refs: #23089
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
MylesBorins added a commit that referenced this issue May 16, 2019
@refack @MylesBorins
test: mark some known flakes
fe21dd3 
PR-URL: #27225
Refs: #26910
Refs: #27219
Refs: #26938
Refs: #23089
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 16, 2019
Merged
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@richardlau richardlau

@BridgeAR BridgeAR

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
flaky-test test
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@refack @nodejs-github-bot @lpinca @richardlau @BridgeAR @ZYSzys @MylesBorins