Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upbenchmark: add benchmark for dns.promises.lookup() #27249
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
benchmark
dns
labels
Apr 16, 2019
richardlau
approved these changes
Apr 16, 2019
richardlau
added
the
promises
label
Apr 16, 2019
Trott
referenced this pull request
Apr 16, 2019
Closed
dns: refactor internal/dns/promises.js #27081
Trott
added
the
author ready
label
Apr 16, 2019
mihalskiy
approved these changes
Apr 16, 2019
addaleax
approved these changes
Apr 16, 2019
benchmark/dns/lookup-promises.js
Outdated
| return; | ||
| } | ||
| await lookup(name, opts); | ||
| cb(); |
This comment has been minimized.
This comment has been minimized.
addaleax
Apr 16, 2019
Member
If we’re using async/await anyway, would using a loop instead of recursive function calls make sense?
This comment has been minimized.
This comment has been minimized.
Trott
force-pushed the
Trott:add-dns-lookup-promises-benchmark
branch
from
82af24d
to
449eee0
Apr 18, 2019
Trott
force-pushed the
Trott:add-dns-lookup-promises-benchmark
branch
from
449eee0
to
57a9ad9
Apr 18, 2019
This comment has been minimized.
This comment has been minimized.
ZYSzys
approved these changes
Apr 18, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in f98679f |
Trott
closed this
Apr 18, 2019
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 18, 2019
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Trott commentedApr 16, 2019
Adding this benchmark will let us check the performance implications of
#27081.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes