Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updeps: patch V8 to 7.4.288.21 #27265
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
V8 Engine
label
Apr 16, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
Apr 16, 2019
This comment has been minimized.
This comment has been minimized.
|
What happened to postmortem metadata
|
This comment has been minimized.
This comment has been minimized.
|
That's very weird. I'll take a look. |
This comment has been minimized.
This comment has been minimized.
|
Caused by: #23027 I'll add a commit to fix this. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjihrig
approved these changes
Apr 17, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
CI is green. Landing |
This comment has been minimized.
This comment has been minimized.
|
Landed in a7d7d4d...8712edf |
mmarchini
closed this
Apr 18, 2019
mmarchini
added a commit
that referenced
this pull request
Apr 18, 2019
mmarchini
added a commit
that referenced
this pull request
Apr 18, 2019
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mmarchini commentedApr 16, 2019
Refs: v8/v8@7.4.288.18...7.4.288.21
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes