util: access process states lazily in debuglog #27281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`debuglog()` depends on `process.pid` and `process.env.NODE_DEBUG`, so it needs to be called lazily in top scopes of internal modules that may be loaded before these run time states are allowed to be accessed. This patch makes its implementation lazy by default, the process states are only accessed when the returned debug function is called for the first time.
joyeecheung
reviewed
Apr 17, 2019
| @@ -31,7 +31,7 @@ function emitWarningIfNeeded(set) { | |||
| } | |||
| } | |||
|
|
|||
| function debuglog(set) { | |||
| function debuglogImpl(set) { | |||
| set = set.toUpperCase(); | |||
| if (!debugs[set]) { | |||
| if (debugEnvRegex.test(set)) { | |||
There was a problem hiding this comment.
Note that since process.env.NODE_DEBUG is saved above during pre-execution, even though the saved value is accessed lazily, it's still saved as soon as possible.
BridgeAR
approved these changes
Apr 17, 2019
lpinca
approved these changes
Apr 17, 2019
richardlau
approved these changes
Apr 17, 2019
ZYSzys
approved these changes
Apr 18, 2019
|
Landed in 2e4ceb5 |
joyeecheung
added a commit
that referenced
this issue
Apr 19, 2019
`debuglog()` depends on `process.pid` and `process.env.NODE_DEBUG`, so it needs to be called lazily in top scopes of internal modules that may be loaded before these run time states are allowed to be accessed. This patch makes its implementation lazy by default, the process states are only accessed when the returned debug function is called for the first time. PR-URL: #27281 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
debuglog()depends onprocess.pidandprocess.env.NODE_DEBUG,so it needs to be called lazily in top scopes of internal modules
that may be loaded before these run time states are allowed to
be accessed. This patch makes its implementation lazy by default,
the process states are only accessed when the returned debug
function is called for the first time.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes