deps: use nghttp2's config.h on all platforms #27283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Apr 17, 2019
joyeecheung
approved these changes
Apr 18, 2019
jasnell
approved these changes
Apr 18, 2019
|
Travis failed with: === release test-crypto-sign-verify ===
Path: parallel/test-crypto-sign-verify
--- stderr ---
assert.js:523
throw err;
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected
Comparison {
+ message: 'error:0908F070:PEM routines:get_header_and_data:short header'
- message: 'bye, bye, library'
}
at Object.<anonymous> (/home/travis/build/nodejs/node/test/parallel/test-crypto-sign-verify.js:42:10)
at Module._compile (internal/modules/cjs/loader.js:766:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:777:10)
at Module.load (internal/modules/cjs/loader.js:635:32)
at Function.Module._load (internal/modules/cjs/loader.js:562:12)
at Function.Module.runMain (internal/modules/cjs/loader.js:833:10)
at internal/main/run_main_module.js:17:11
Command: out/Release/node /home/travis/build/nodejs/node/test/parallel/test-crypto-sign-verify.jsUnrelated? |
Fix warnings about use of htonl(), etc. by including config.h for all platforms, defining HAVE_ARPA_INET_H on non-Windows, and therefore including <arpa/inet.h>, which defines the host to network byte order conversion functions.
b35242b
to
454d6dd
Compare
|
Should not be related, I wrote that test in #27157, and it passed there, except travis's CI state isn't visible anymore. I found some other recent travis jobs that include #27157, and they passed, like https://travis-ci.com/nodejs/node/builds/108825880 I rebased against master, and repushed. |
refack
approved these changes
Apr 18, 2019
|
Landed in 90cf2d5 |
sam-github
added a commit
that referenced
this issue
Apr 22, 2019
Fix warnings about use of htonl(), etc. by including config.h for all platforms, defining HAVE_ARPA_INET_H on non-Windows, and therefore including <arpa/inet.h>, which defines the host to network byte order conversion functions. PR-URL: #27283 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix warnings about use of htonl(), etc. by including config.h for all
platforms, defining HAVE_ARPA_INET_H on non-Windows, and therefore
including <arpa/inet.h>, which defines the host to network byte order
conversion functions.
--
This works on Linux, I'll see what ci says about the other platforms.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes