★ wanayoo — archive 1999 https://github.com/nodejs/node-addon-api/pull/766/commitsNouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce include_dir for use with gyp in a scalar context #766

Closed

Commits on Jul 14, 2020

  1. Introduce include_dir for use with gyp in a scalar context

    Deprecate use of `include` in an gyp array context, which
    happens to work when paths are absolute, but can fail on Windows
    when paths are relative and a gyp file contains multiple entries
    in its `include_dirs` directive.
    
    This change corrects documentation and tooling, adds support for
    relative paths (e.g. those containing whitespace) in a backwards
    compatible manner and makes the approach holistically consistent
    with that used by nan.
    lovell committed Jul 14, 2020