★ wanayoo — archive 1999 https://github.com/nodejs/node-addon-api/pull/787Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor threadsafe_function test with async/await #787

Closed
wants to merge 1 commit into from
Closed

test: refactor threadsafe_function test with async/await #787

wants to merge 1 commit into from

Conversation

Velmisov
Copy link
Contributor

@Velmisov Velmisov commented Aug 7, 2020

KevinEady
KevinEady approved these changes Aug 9, 2020
View changes
Copy link
Contributor

@KevinEady KevinEady left a comment

👍 LGTM! I was able to also use this format in my draft tsfnex pull

mhdawson
mhdawson approved these changes Aug 24, 2020
View changes
Copy link
Member

@mhdawson mhdawson left a comment

LGTM

mhdawson added a commit that referenced this issue Aug 24, 2020
@Velmisov @mhdawson
test: refactor test to use async/await
2bc45bb 
Refactor threadsafe_function test with async/await

PR-URL: #787
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member

@mhdawson mhdawson commented Aug 24, 2020

Landed as 2bc45bb

@mhdawson mhdawson closed this Aug 24, 2020
@NickNaso NickNaso mentioned this pull request Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinEady KevinEady

@mhdawson mhdawson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Velmisov @mhdawson @KevinEady