★ wanayoo — archive 1999 https://github.com/php-censor/php-censor/pull/283Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Postgres SSLMODE connection option #283

Merged
merged 14 commits into from Feb 24, 2019

Conversation

@mikebronner
Copy link
Contributor

@mikebronner mikebronner commented Feb 21, 2019 •

Description of change

The goal of this PR is to allow for a Postgres connection over SSL for the main php-censor database.

Next Steps

  • Add steps to install command.
  • Test install command.
  • Add logic for sslmode to regular database connection.
  • Test migration of install command.
  • Test functionality of site once installed.
  • Test non-interactive install command.

Challenges

  • Figure out how to get Phynx to run migrations with sslmode=require in its connection string.

Fixes #282

@corpsee corpsee self-requested a review Feb 21, 2019
@corpsee corpsee added this to the Version 1.x.0 (minor) milestone Feb 21, 2019
@corpsee
Copy link
Member

@corpsee corpsee commented Feb 21, 2019

Issue #282. @mikebronner It isn't clear... Do you want to use SSL connection with main PHP Censor DB or with Postgres plugin? It isn't same.

@mikebronner
Copy link
Contributor Author

@mikebronner mikebronner commented Feb 21, 2019

@corpsee Sorry, and I was looking in the wrong place. I am trying to use it with the main php-censor database.

@mikebronner mikebronner changed the title [WIP] Add Postgres SSLMODE connection option [WIP] Feature: Add Postgres SSLMODE connection option Feb 21, 2019
WIP
@mikebronner
Copy link
Contributor Author

@mikebronner mikebronner commented Feb 21, 2019

@corpsee Would you mind taking a look at this PR? I have it in a functional state at this point. Any feedback welcome. Thanks! :)

@mikebronner mikebronner changed the title [WIP] Feature: Add Postgres SSLMODE connection option Feature: Add Postgres SSLMODE connection option Feb 21, 2019
src/Command/InstallCommand.php Outdated Show resolved Hide resolved
@corpsee
Copy link
Member

@corpsee corpsee commented Feb 23, 2019 •

@mikebronner Also could you add infotmation about new option to application config documentation?

src/Command/InstallCommand.php Outdated Show resolved Hide resolved
src/Command/InstallCommand.php Outdated Show resolved Hide resolved
@corpsee
Copy link
Member

@corpsee corpsee commented Feb 23, 2019

@mikebronner Thank you for the great work! 👍

@mikebronner
Copy link
Contributor Author

@mikebronner mikebronner commented Feb 23, 2019

@corpsee Thanks for the feedback. I believe I have made all requested changes. Let me know if I missed anything. :)

@corpsee corpsee merged commit fa2aabd into php-censor:master Feb 24, 2019
4 checks passed
4 checks passed
PHP Censor PHP Censor build passed.
Details
codecov/patch 32% of diff hit (target 27%)
Details
codecov/project 27% (+<1%) compared to 26a697e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@corpsee
Copy link
Member

@corpsee corpsee commented Feb 24, 2019

@mikebronner Good. Thanks!

@corpsee
Copy link
Member

@corpsee corpsee commented Feb 24, 2019

PR merged to master branch and will be released with version 1.1.0.

@corpsee corpsee modified the milestones: Version 1.1.0 (minor), 1.1.0 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.